-
-
Notifications
You must be signed in to change notification settings - Fork 669
Migrate the settings page to Tailwind UI and Blade UI Kit #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This looks super good! But I'm thinking we can ditch the menu on the left entirely because it's already present in the navigation dropdown. I don't feel it serves much purpose there. Sort of like this screen here: https://tailwindui.com/components/application-ui/page-examples/settings-screens#component-c29fe3f9f780c97a58f08453fc6bbec8 |
My thinking was that as we add more user features, the navbar will get a bit bloated. I liked the idea of having a single navbar item that takes you do the user area and you can nvaigate your way from there. I'm happyt to be talked around though 😄 |
|
It just feels really out of place to me. Especially since the menu will disappear if you click any item except the settings. The navbar menu just has a handful of items and isn't bloated at all I think. Now that we have a single page for all our user settings I think it makes sense to just have the page centered without a menu next to it. If we have lots of extra settings in the future we can revise of course. |
My plan was to make the sidebar persistent across all user pages so in the long-run, it wouldn't disappear. I'm happy to park that idea for now and go with the single centered column. Not sure when I'll be able to get around to it, but will try and find some time next week. |
|
How would that look for the profile page though? What happens for the profile page when you're not logged in? I think it's best to remove it for now and revisit it when we actually need it. |
|
@joedixon cool. Tests are failing it seems. |
That will teach me to change the button text. Should be good now. |
driesvints
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. I left some remarks.
A few notes in general:
- Always try to leave some breathing room before or after an if directive in Blade views when there's elements on the same level before or after it.
- If directives always have a space between
ifand the opening( - I see a lot of
{{syntax being used in Blade component value attributes. Did you test all of these? Because afaik this isn't supported on Blade components. You should try to use the:value="Auth::user()->email"syntax instead.
resources/views/vendor/blade-ui-kit/components/forms/inputs/input.blade.php
Show resolved
Hide resolved
resources/views/vendor/blade-ui-kit/components/forms/inputs/input.blade.php
Show resolved
Hide resolved
resources/views/vendor/blade-ui-kit/components/forms/inputs/input.blade.php
Show resolved
Hide resolved
resources/views/vendor/blade-ui-kit/components/forms/inputs/textarea.blade.php
Outdated
Show resolved
Hide resolved
resources/views/vendor/blade-ui-kit/components/forms/inputs/textarea.blade.php
Outdated
Show resolved
Hide resolved
|
@joedixon tests seem to be failing. |
Fixed! |


I looked through the settings pages of Tailwind UI and like the layout I have opted for. This did mean merging the profile and the password settings onto one page (a separate form and panel for each).
Also resolves #576