From 6fd5e1f8ece089a6b4d9d17fcd963a4a8135ddb6 Mon Sep 17 00:00:00 2001 From: faissaloux Date: Tue, 30 Nov 2021 22:35:53 +0100 Subject: [PATCH 1/2] switch to match --- app/Http/Requests/CreateReplyRequest.php | 7 +++---- app/View/Components/Modal.php | 13 +++++-------- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/app/Http/Requests/CreateReplyRequest.php b/app/Http/Requests/CreateReplyRequest.php index 54224b6d0..03fa0276d 100644 --- a/app/Http/Requests/CreateReplyRequest.php +++ b/app/Http/Requests/CreateReplyRequest.php @@ -25,10 +25,9 @@ public function replyAble(): ReplyAble private function findReplyAble(int $id, string $type): ReplyAble { - switch ($type) { - case Thread::TABLE: - return Thread::find($id); - } + return match($type) { + Thread::TABLE => Thread::find($id), + }; abort(404); } diff --git a/app/View/Components/Modal.php b/app/View/Components/Modal.php index 672b35907..0f6c7683c 100644 --- a/app/View/Components/Modal.php +++ b/app/View/Components/Modal.php @@ -32,13 +32,10 @@ public function render() public function method() { - switch ($this->type) { - case 'delete': - return 'delete'; - case 'update': - return 'put'; - default: - return 'post'; - } + return match($this->type) { + 'delete' => 'delete', + 'update' => 'put', + default => 'post', + }; } } From e71ce70ba49eceadadf4ec8fae441dff5b72fb71 Mon Sep 17 00:00:00 2001 From: faissaloux Date: Tue, 30 Nov 2021 22:37:41 +0100 Subject: [PATCH 2/2] apply StyleCI fixes --- app/Http/Requests/CreateReplyRequest.php | 2 +- app/View/Components/Modal.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Http/Requests/CreateReplyRequest.php b/app/Http/Requests/CreateReplyRequest.php index 03fa0276d..6688f2154 100644 --- a/app/Http/Requests/CreateReplyRequest.php +++ b/app/Http/Requests/CreateReplyRequest.php @@ -25,7 +25,7 @@ public function replyAble(): ReplyAble private function findReplyAble(int $id, string $type): ReplyAble { - return match($type) { + return match ($type) { Thread::TABLE => Thread::find($id), }; diff --git a/app/View/Components/Modal.php b/app/View/Components/Modal.php index 0f6c7683c..09180aebf 100644 --- a/app/View/Components/Modal.php +++ b/app/View/Components/Modal.php @@ -32,7 +32,7 @@ public function render() public function method() { - return match($this->type) { + return match ($this->type) { 'delete' => 'delete', 'update' => 'put', default => 'post',