From 36f7449946561b97b7ba10e7ccb577afcad0ace4 Mon Sep 17 00:00:00 2001 From: StyleCI Bot Date: Mon, 4 Nov 2024 09:38:31 +0000 Subject: [PATCH] Apply fixes from StyleCI --- app/Helpers/Cetak.php | 1 - app/Helpers/Helper.php | 9 ++++----- app/Models/AnggaranKerangkaAcuan.php | 1 - app/Models/ArsipDokumen.php | 4 +++- app/Models/BarangPersediaan.php | 4 +++- app/Models/DaftarKontrakMitra.php | 1 - app/Models/KontrakMitra.php | 1 - app/Nova/Actions/GenerateKontrakMitra.php | 2 +- app/Nova/BarangPersediaan.php | 2 +- app/Policies/BarangPersediaanPolicy.php | 11 ++++++----- app/Policies/HonorKegiatanPolicy.php | 16 ++++++++-------- app/Policies/KerangkaAcuanPolicy.php | 2 +- ...03_083040_create_master_persediaans_table.php | 4 ++-- 13 files changed, 29 insertions(+), 29 deletions(-) diff --git a/app/Helpers/Cetak.php b/app/Helpers/Cetak.php index 0781cddb..7445d87a 100644 --- a/app/Helpers/Cetak.php +++ b/app/Helpers/Cetak.php @@ -374,6 +374,5 @@ public static function validate($jenis, $model_id) 'Mohon Generate BAST terlebih dahulu sebelum mencetak!' ); } - } } diff --git a/app/Helpers/Helper.php b/app/Helpers/Helper.php index 317271ad..6233be89 100644 --- a/app/Helpers/Helper.php +++ b/app/Helpers/Helper.php @@ -586,7 +586,7 @@ public static function isAkunHonorChanged($mak_old, $mak_new) /** * Memeriksa apakah kode akun merupakan akun persediaan. * - * @param string $mak Kode akun yang akan diperiksa. + * @param string $mak Kode akun yang akan diperiksa. * @return bool Mengembalikan true jika kode akun merupakan akun persediaan, sebaliknya false. */ public static function isAkunPersediaan(string $mak): bool @@ -600,8 +600,8 @@ public static function isAkunPersediaan(string $mak): bool * Fungsi ini membandingkan dua nilai akun persediaan dan menentukan apakah * ada perubahan antara nilai lama dan nilai baru. * - * @param string $mak_old Nilai akun persediaan lama. - * @param string $mak_new Nilai akun persediaan baru. + * @param string $mak_old Nilai akun persediaan lama. + * @param string $mak_new Nilai akun persediaan baru. * @return bool Mengembalikan true jika akun persediaan berubah, sebaliknya false. */ public static function isAkunPersediaanChanged($mak_old, $mak_new) @@ -938,7 +938,6 @@ public static function makeKontrakMitra($kontrak_mitra_id) ->toArray(); } - /** * Get property from collection. * @@ -1015,7 +1014,7 @@ public static function getLatestHargaSatuanId($tanggal) /** * Mengambil harga satuan terbaru berdasarkan tanggal yang diberikan. * - * @param string $tanggal Tanggal untuk memfilter data harga satuan. + * @param string $tanggal Tanggal untuk memfilter data harga satuan. * @return HargaSatuan|null Objek HargaSatuan terbaru atau null jika tidak ditemukan. */ public static function getLatestHargaSatuan($tanggal) diff --git a/app/Models/AnggaranKerangkaAcuan.php b/app/Models/AnggaranKerangkaAcuan.php index 0ed51bcc..79fe04c7 100644 --- a/app/Models/AnggaranKerangkaAcuan.php +++ b/app/Models/AnggaranKerangkaAcuan.php @@ -56,7 +56,6 @@ protected static function booted(): void $pembelian->save(); } } - }); static::deleting(function (AnggaranKerangkaAcuan $anggaranKak) { $ids = HonorKegiatan::where('anggaran_kerangka_acuan_id', $anggaranKak->id)->pluck('id')->toArray(); diff --git a/app/Models/ArsipDokumen.php b/app/Models/ArsipDokumen.php index 04608e2a..1057da1e 100644 --- a/app/Models/ArsipDokumen.php +++ b/app/Models/ArsipDokumen.php @@ -4,4 +4,6 @@ use Illuminate\Database\Eloquent\Model; -class ArsipDokumen extends Model {} +class ArsipDokumen extends Model +{ +} diff --git a/app/Models/BarangPersediaan.php b/app/Models/BarangPersediaan.php index 91afef21..489e727b 100644 --- a/app/Models/BarangPersediaan.php +++ b/app/Models/BarangPersediaan.php @@ -4,4 +4,6 @@ use Illuminate\Database\Eloquent\Model; -class BarangPersediaan extends Model {} +class BarangPersediaan extends Model +{ +} diff --git a/app/Models/DaftarKontrakMitra.php b/app/Models/DaftarKontrakMitra.php index 699258db..cb9c84db 100644 --- a/app/Models/DaftarKontrakMitra.php +++ b/app/Models/DaftarKontrakMitra.php @@ -64,6 +64,5 @@ protected static function booted(): void } } }); - } } diff --git a/app/Models/KontrakMitra.php b/app/Models/KontrakMitra.php index 06664bea..0e078113 100644 --- a/app/Models/KontrakMitra.php +++ b/app/Models/KontrakMitra.php @@ -50,7 +50,6 @@ protected static function booted(): void if ($kontrak->isDirty()) { $kontrak->status = $kontrak->status === 'dibuat' ? 'diubah' : 'outdated'; } - }); } } diff --git a/app/Nova/Actions/GenerateKontrakMitra.php b/app/Nova/Actions/GenerateKontrakMitra.php index 5a23c882..49137357 100644 --- a/app/Nova/Actions/GenerateKontrakMitra.php +++ b/app/Nova/Actions/GenerateKontrakMitra.php @@ -83,7 +83,7 @@ public function handle(ActionFields $fields, Collection $models) ->whereIn('honor_kegiatan_id', $honorKegiatanIds) ->update(['daftar_kontrak_mitra_id' => $daftar_mitra->id]); } - $model::where('id',$model->id)->update(['status' => 'digenerate']); + $model::where('id', $model->id)->update(['status' => 'digenerate']); $ids = DaftarKontrakMitra::where('updated_at', null)->get()->pluck('id'); DaftarKontrakMitra::destroy($ids); diff --git a/app/Nova/BarangPersediaan.php b/app/Nova/BarangPersediaan.php index 889fcb1d..87f7c519 100644 --- a/app/Nova/BarangPersediaan.php +++ b/app/Nova/BarangPersediaan.php @@ -44,7 +44,7 @@ public static function label() public function fields(NovaRequest $request) { return [ - + ]; } diff --git a/app/Policies/BarangPersediaanPolicy.php b/app/Policies/BarangPersediaanPolicy.php index eebf9557..77015586 100644 --- a/app/Policies/BarangPersediaanPolicy.php +++ b/app/Policies/BarangPersediaanPolicy.php @@ -4,7 +4,8 @@ use App\Helpers\Policy; -class BarangPersediaanPolicy{ +class BarangPersediaanPolicy +{ /** * Determine whether the user can view any models. */ @@ -21,8 +22,8 @@ public function viewAny(): bool public function view(): bool { return Policy::make() - ->allowedFor('koordinator,anggota,bmn') - ->get(); + ->allowedFor('koordinator,anggota,bmn') + ->get(); } /** @@ -31,8 +32,8 @@ public function view(): bool public function create(): bool { return Policy::make() - ->allowedFor('koordinator,anggota,bmn') - ->get(); + ->allowedFor('koordinator,anggota,bmn') + ->get(); } /** diff --git a/app/Policies/HonorKegiatanPolicy.php b/app/Policies/HonorKegiatanPolicy.php index 2780fda3..e4b3c99f 100644 --- a/app/Policies/HonorKegiatanPolicy.php +++ b/app/Policies/HonorKegiatanPolicy.php @@ -52,10 +52,10 @@ public function create(): bool public function update(User $user, HonorKegiatan $honor): bool { return Policy::make() - ->allowedFor('koordinator,anggota') - ->withYear($honor->tahun) - ->andEqual($honor->unit_kerja_id, Helper::getDataPegawaiByUserId($user->id, now())->unit_kerja_id) - ->get(); + ->allowedFor('koordinator,anggota') + ->withYear($honor->tahun) + ->andEqual($honor->unit_kerja_id, Helper::getDataPegawaiByUserId($user->id, now())->unit_kerja_id) + ->get(); } /** @@ -64,10 +64,10 @@ public function update(User $user, HonorKegiatan $honor): bool public function delete(User $user, HonorKegiatan $honor): bool { return Policy::make() - ->allowedFor('koordinator,anggota') - ->withYear($honor->tahun) - ->andEqual($honor->unit_kerja_id, Helper::getDataPegawaiByUserId($user->id, now())->unit_kerja_id) - ->get(); + ->allowedFor('koordinator,anggota') + ->withYear($honor->tahun) + ->andEqual($honor->unit_kerja_id, Helper::getDataPegawaiByUserId($user->id, now())->unit_kerja_id) + ->get(); } /** diff --git a/app/Policies/KerangkaAcuanPolicy.php b/app/Policies/KerangkaAcuanPolicy.php index cf85b93a..e3fcd8a8 100644 --- a/app/Policies/KerangkaAcuanPolicy.php +++ b/app/Policies/KerangkaAcuanPolicy.php @@ -31,6 +31,7 @@ public function view(User $user, KerangkaAcuan $kerangkaAcuan): bool ->andEqual($kerangkaAcuan->unit_kerja_id, Helper::getDataPegawaiByUserId($user->id, now())->unit_kerja_id) ->get(); } + return Policy::make() ->notAllowedFor('admin') ->withYear(Helper::getYearFromDate($kerangkaAcuan->tanggal)) @@ -90,5 +91,4 @@ public function runAction(User $user, KerangkaAcuan $kerangkaAcuan): bool ->withYear(Helper::getYearFromDate($kerangkaAcuan->tanggal)) ->get(); } - } diff --git a/database/migrations/2024_11_03_083040_create_master_persediaans_table.php b/database/migrations/2024_11_03_083040_create_master_persediaans_table.php index 1767b40d..be5b5c65 100644 --- a/database/migrations/2024_11_03_083040_create_master_persediaans_table.php +++ b/database/migrations/2024_11_03_083040_create_master_persediaans_table.php @@ -13,9 +13,9 @@ public function up(): void { Schema::create('master_persediaans', function (Blueprint $table) { $table->id(); - $table->string('kode',20)->nullable()->unique(); + $table->string('kode', 20)->nullable()->unique(); $table->string('barang')->nullable(); - $table->string('satuan',20)->nullable(); + $table->string('satuan', 20)->nullable(); $table->timestamps(); }); }