From 8a61b171defdb27e193f425f6455f3a1c42d399b Mon Sep 17 00:00:00 2001 From: StyleCI Bot Date: Mon, 2 Dec 2024 21:19:19 +0000 Subject: [PATCH] Apply fixes from StyleCI --- app/Helpers/Helper.php | 3 ++- app/Models/DaftarHonorMitra.php | 1 - app/Models/IzinKeluar.php | 4 ---- app/Models/PerjalananDinas.php | 1 - app/Nova/BarangPersediaan.php | 4 ++-- app/Nova/BastMitra.php | 6 +++--- app/Nova/Filters/GenerateNaskah.php | 1 - app/Nova/Filters/RoFilter.php | 2 +- app/Nova/IzinKeluar.php | 4 ++-- app/Nova/KontrakMitra.php | 10 +++++----- app/Nova/Lenses/RealisasiAnggaran.php | 3 ++- app/Nova/Lenses/RekapBarangPersediaan.php | 2 +- app/Nova/Lenses/RekapHonorMitra.php | 2 +- app/Nova/Lenses/RencanaPenarikanDana.php | 2 +- app/Nova/MataAnggaran.php | 2 +- app/Nova/Metrics/RealisasiPerJenisBelanja.php | 2 +- app/Nova/Metrics/RencanaPenarikanPerJenisBelanja.php | 2 +- app/Nova/PembelianPersediaan.php | 1 - app/Nova/PermintaanPersediaan.php | 2 +- app/Nova/User.php | 2 +- app/Policies/BastMitraPolicy.php | 2 +- app/Policies/DaftarSp2dPolicy.php | 4 ++-- app/Policies/HonorKegiatanPolicy.php | 4 ++-- app/Policies/KontrakMitraPolicy.php | 2 +- app/Policies/NaskahKeluarPolicy.php | 2 +- app/Policies/NaskahMasukPolicy.php | 2 +- app/Policies/RewardPegawaiPolicy.php | 2 +- 27 files changed, 34 insertions(+), 40 deletions(-) diff --git a/app/Helpers/Helper.php b/app/Helpers/Helper.php index 38edccdb..4814b1e2 100644 --- a/app/Helpers/Helper.php +++ b/app/Helpers/Helper.php @@ -214,6 +214,7 @@ public static function formatTelepon($telepon) $wa = str_replace('+62 08', '628', $telepon); $wa = str_replace('+62 ', '62', $wa); $wa = str_replace('-', '', $wa); + return "https://wa.me/{$wa}"; } @@ -293,7 +294,7 @@ public static function formatUang($angka) public static function asterikNik($nik) { - return substr($nik, 0, 4) . str_repeat('*', 10) . substr($nik, 14); + return substr($nik, 0, 4).str_repeat('*', 10).substr($nik, 14); } /** diff --git a/app/Models/DaftarHonorMitra.php b/app/Models/DaftarHonorMitra.php index 6e8670e6..57732562 100644 --- a/app/Models/DaftarHonorMitra.php +++ b/app/Models/DaftarHonorMitra.php @@ -50,7 +50,6 @@ protected static function booted(): void ->type('error') ); } - } if ($honor->volume_realisasi != $honor->volume_target) { $honor->status_realisasi = $honor->volume_realisasi < $honor->volume_target diff --git a/app/Models/IzinKeluar.php b/app/Models/IzinKeluar.php index 6feb64d2..b888716c 100644 --- a/app/Models/IzinKeluar.php +++ b/app/Models/IzinKeluar.php @@ -2,13 +2,9 @@ namespace App\Models; -use App\Helpers\Helper; use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Relations\BelongsTo; use Illuminate\Support\Facades\Auth; -use Laravel\Nova\Notifications\NovaNotification; -use Laravel\Nova\Nova; -use Laravel\Nova\URL; class IzinKeluar extends Model { diff --git a/app/Models/PerjalananDinas.php b/app/Models/PerjalananDinas.php index ef1b8e42..1305005e 100644 --- a/app/Models/PerjalananDinas.php +++ b/app/Models/PerjalananDinas.php @@ -48,7 +48,6 @@ public function kepala(): BelongsTo return $this->belongsTo(User::class, 'kepala_user_id'); } - public function daftarPesertaPerjalanan(): HasMany { return $this->hasMany(DaftarPesertaPerjalanan::class, 'perjalanan_dinas_id'); diff --git a/app/Nova/BarangPersediaan.php b/app/Nova/BarangPersediaan.php index b4dfc607..428e8e9b 100644 --- a/app/Nova/BarangPersediaan.php +++ b/app/Nova/BarangPersediaan.php @@ -76,13 +76,13 @@ public function fieldsforIndex(NovaRequest $request) return [ Text::make('Nama Barang', 'barang'), Text::make('Kode Barang Detail', 'masterPersediaan.kode') - ->hideFromIndex(!Policy::make() + ->hideFromIndex(! Policy::make() ->allowedFor('bmn') ->get()) ->copyable(), Text::make('Kode Barang Sakti', 'masterPersediaan.kode') ->displayUsing(fn ($value) => substr($value, 0, 10)) - ->hideFromIndex(!Policy::make() + ->hideFromIndex(! Policy::make() ->allowedFor('ppk,bmn') ->get()) ->copyable(), diff --git a/app/Nova/BastMitra.php b/app/Nova/BastMitra.php index 7ab6596b..4c1f7f46 100644 --- a/app/Nova/BastMitra.php +++ b/app/Nova/BastMitra.php @@ -87,13 +87,13 @@ public function fields(NovaRequest $request) return Helper::terbilangTanggal($tanggal); }) ->sortable() - ->readonly(!Policy::make()->allowedFor('ppk')->get()) + ->readonly(! Policy::make()->allowedFor('ppk')->get()) ->filterable() ->rules('required', 'before_or_equal:today', 'after_or_equal:'.$akhir), Select::make('Klasifikasi Arsip', 'kode_arsip_id') ->searchable() ->hideFromIndex() - ->readonly(!Policy::make()->allowedFor('ppk')->get()) + ->readonly(! Policy::make()->allowedFor('ppk')->get()) ->displayUsing(fn ($kode) => Helper::getPropertyFromCollection(KodeArsip::cache()->get('all')->where('id', $kode)->first(), 'kode')) ->dependsOn(['tanggal_bast'], function (Select $field, NovaRequest $request, FormData $formData) { $default_naskah = NaskahDefault::cache() @@ -106,7 +106,7 @@ public function fields(NovaRequest $request) Select::make('Pejabat Pembuat Komitmen', 'ppk_user_id') ->rules('required') ->searchable() - ->readonly(!Policy::make()->allowedFor('ppk')->get()) + ->readonly(! Policy::make()->allowedFor('ppk')->get()) ->onlyOnForms() ->displayUsing(fn ($id) => Helper::getPropertyFromCollection(Helper::getPegawaiByUserId($id), 'name')) ->dependsOn('tanggal_bast', function (Select $field, NovaRequest $request, FormData $formData) { diff --git a/app/Nova/Filters/GenerateNaskah.php b/app/Nova/Filters/GenerateNaskah.php index 5a9b9726..a7bfb9ec 100644 --- a/app/Nova/Filters/GenerateNaskah.php +++ b/app/Nova/Filters/GenerateNaskah.php @@ -2,7 +2,6 @@ namespace App\Nova\Filters; -use App\Models\KodeArsip; use Laravel\Nova\Filters\Filter; use Laravel\Nova\Http\Requests\NovaRequest; diff --git a/app/Nova/Filters/RoFilter.php b/app/Nova/Filters/RoFilter.php index d66162ed..32fc5fe1 100644 --- a/app/Nova/Filters/RoFilter.php +++ b/app/Nova/Filters/RoFilter.php @@ -41,6 +41,6 @@ public function apply(NovaRequest $request, $query, $value) */ public function options(NovaRequest $request) { - return array_flip(Helper::setOptionsRo(Helper::getPropertyFromCollection(Dipa::cache()->get('all')->where('tahun', session('year'))->first(),'id'))); + return array_flip(Helper::setOptionsRo(Helper::getPropertyFromCollection(Dipa::cache()->get('all')->where('tahun', session('year'))->first(), 'id'))); } } diff --git a/app/Nova/IzinKeluar.php b/app/Nova/IzinKeluar.php index e78885bf..2a20c323 100644 --- a/app/Nova/IzinKeluar.php +++ b/app/Nova/IzinKeluar.php @@ -94,7 +94,7 @@ public function fields(NovaRequest $request) Time::make('Jam Kembali', 'kembali') ->sortable() ->hideWhenCreating() - ->updateRules('nullable', 'bail','after_or_equal:keluar'), + ->updateRules('nullable', 'bail', 'after_or_equal:keluar'), AdvancedImage::make('Bukti Dukung', 'bukti') ->disk('izin_keluar') ->croppable() @@ -104,7 +104,7 @@ public function fields(NovaRequest $request) ->hideFromIndex() ->hideWhenCreating() ->sortable(), - Text::make('Bukti Dukung', fn() => $this->bukti ? 'Ada' : 'Tidak Ada') + Text::make('Bukti Dukung', fn () => $this->bukti ? 'Ada' : 'Tidak Ada') ->onlyOnIndex(), ]), diff --git a/app/Nova/KontrakMitra.php b/app/Nova/KontrakMitra.php index 6a43b434..b05988ad 100644 --- a/app/Nova/KontrakMitra.php +++ b/app/Nova/KontrakMitra.php @@ -98,13 +98,13 @@ public function fields(NovaRequest $request) ->rules('required', 'before_or_equal:today')->displayUsing(function ($tanggal) { return Helper::terbilangTanggal($tanggal); }) - ->readonly(!Policy::make()->allowedFor('ppk')->get()) + ->readonly(! Policy::make()->allowedFor('ppk')->get()) ->filterable() ->sortable(), Select::make('Klasifikasi Arsip', 'kode_arsip_id') ->searchable() ->hideFromIndex() - ->readonly(!Policy::make()->allowedFor('ppk')->get()) + ->readonly(! Policy::make()->allowedFor('ppk')->get()) ->displayUsing(fn ($kode) => Helper::getPropertyFromCollection(KodeArsip::cache()->get('all')->where('id', $kode)->first(), 'kode')) ->dependsOn(['tanggal_spk'], function (Select $field, NovaRequest $request, FormData $formData) { $default_naskah = NaskahDefault::cache() @@ -118,13 +118,13 @@ public function fields(NovaRequest $request) ->rules('required', 'after_or_equal:tanggal_spk')->displayUsing(function ($tanggal) { return Helper::terbilangTanggal($tanggal); }) - ->readonly(!Policy::make()->allowedFor('ppk')->get()) + ->readonly(! Policy::make()->allowedFor('ppk')->get()) ->hideFromIndex(), Date::make('Tanggal Selesai Kontrak', 'akhir_kontrak') ->rules('required', 'after_or_equal:awal')->displayUsing(function ($tanggal) { return Helper::terbilangTanggal($tanggal); }) - ->readonly(!Policy::make()->allowedFor('ppk')->get()) + ->readonly(! Policy::make()->allowedFor('ppk')->get()) ->hideFromIndex(), BelongsTo::make('Pejabat Pembuat Komitmen', 'ppk', 'App\Nova\User') ->exceptOnForms() @@ -132,7 +132,7 @@ public function fields(NovaRequest $request) Select::make('Pejabat Pembuat Komitmen', 'ppk_user_id') ->rules('required') ->searchable() - ->readonly(!Policy::make()->allowedFor('ppk')->get()) + ->readonly(! Policy::make()->allowedFor('ppk')->get()) ->onlyOnForms() ->displayUsing(fn ($id) => Helper::getPropertyFromCollection(Helper::getPegawaiByUserId($id), 'name')) ->dependsOn('tanggal_spk', function (Select $field, NovaRequest $request, FormData $formData) { diff --git a/app/Nova/Lenses/RealisasiAnggaran.php b/app/Nova/Lenses/RealisasiAnggaran.php index 0b6996ca..4cc1bb27 100644 --- a/app/Nova/Lenses/RealisasiAnggaran.php +++ b/app/Nova/Lenses/RealisasiAnggaran.php @@ -32,6 +32,7 @@ class RealisasiAnggaran extends Lens public function name() { $tanggal = Helper::terbilangTanggal(Helper::getPropertyFromCollection(Dipa::cache()->get('all')->where('tahun', session('year'))->first(), 'tanggal_realisasi')); + return $tanggal ? 'Realisasi SP2D per '.Helper::terbilangTanggal(Dipa::cache()->get('all')->where('tahun', session('year'))->first()->tanggal_realisasi) : 'Realisasi SP2D'; } @@ -43,7 +44,7 @@ public function name() */ public static function query(LensRequest $request, $query) { - $dipa_id = Helper::getPropertyFromCollection(Dipa::cache()->get('all')->where('tahun', session('year'))->first(),'id'); + $dipa_id = Helper::getPropertyFromCollection(Dipa::cache()->get('all')->where('tahun', session('year'))->first(), 'id'); $filtered_bulan = Helper::parseFilterFromUrl(request()->headers->get('referer'), 'realisasi-anggarans_filter', 'App\\Nova\\Filters\\BulanFilter', date('m')); return $request->withOrdering($request->withFilters( diff --git a/app/Nova/Lenses/RekapBarangPersediaan.php b/app/Nova/Lenses/RekapBarangPersediaan.php index e5519f73..70fa959d 100644 --- a/app/Nova/Lenses/RekapBarangPersediaan.php +++ b/app/Nova/Lenses/RekapBarangPersediaan.php @@ -52,7 +52,7 @@ public static function query(LensRequest $request, $query) 'barang_persediaans.master_persediaan_id') ->whereNotNull('tanggal_transaksi'); }) - ->groupBy('master_persediaans.id','master_persediaans.kode', 'master_persediaans.satuan', 'master_persediaans.barang') + ->groupBy('master_persediaans.id', 'master_persediaans.kode', 'master_persediaans.satuan', 'master_persediaans.barang') ->joinSub($displayed, 'displayed', function (JoinClause $join) { $join->on('displayed.master_persediaan_id', '=', 'master_persediaans.id'); }), 'master_persediaans') diff --git a/app/Nova/Lenses/RekapHonorMitra.php b/app/Nova/Lenses/RekapHonorMitra.php index 8ce6430b..37790c12 100644 --- a/app/Nova/Lenses/RekapHonorMitra.php +++ b/app/Nova/Lenses/RekapHonorMitra.php @@ -61,7 +61,7 @@ public static function query(LensRequest $request, $query) ->join('daftar_honor_mitras', 'mitras.id', '=', 'daftar_honor_mitras.mitra_id') ->join('honor_kegiatans', 'honor_kegiatans.id', '=', 'daftar_honor_mitras.honor_kegiatan_id') ->join('jenis_kontraks', 'jenis_kontraks.id', '=', 'honor_kegiatans.jenis_kontrak_id') - ->groupBy('bulan', 'mitra_id', 'nama', 'nik', 'sbml', 'jenis_kontrak_id','honor_kegiatan_id', 'volume_realisasi', 'harga_satuan') + ->groupBy('bulan', 'mitra_id', 'nama', 'nik', 'sbml', 'jenis_kontrak_id', 'honor_kegiatan_id', 'volume_realisasi', 'harga_satuan') ->orderBy('jenis_kontrak_id', 'asc') ->orderBy('bulan', 'desc') ->orderBy('nilai_kontrak', 'desc')); diff --git a/app/Nova/Lenses/RencanaPenarikanDana.php b/app/Nova/Lenses/RencanaPenarikanDana.php index a5edf626..369ab7d0 100644 --- a/app/Nova/Lenses/RencanaPenarikanDana.php +++ b/app/Nova/Lenses/RencanaPenarikanDana.php @@ -38,7 +38,7 @@ public function name() */ public static function query(LensRequest $request, $query) { - $dipa_id = Helper::getPropertyFromCollection(Dipa::cache()->get('all')->where('tahun', session('year'))->first(),'id'); + $dipa_id = Helper::getPropertyFromCollection(Dipa::cache()->get('all')->where('tahun', session('year'))->first(), 'id'); $filtered_bulan = Helper::parseFilterFromUrl(request()->headers->get('referer'), 'realisasi-anggarans_filter', 'App\\Nova\\Filters\\BulanFilter', date('m')); $filtered_bulan = $filtered_bulan ?: date('m'); diff --git a/app/Nova/MataAnggaran.php b/app/Nova/MataAnggaran.php index 43ab4e8a..1101f5cd 100644 --- a/app/Nova/MataAnggaran.php +++ b/app/Nova/MataAnggaran.php @@ -39,7 +39,7 @@ public function subtitle() return $this->mak; } - /** + /** * Get the searchable columns for the resource. * * @return array diff --git a/app/Nova/Metrics/RealisasiPerJenisBelanja.php b/app/Nova/Metrics/RealisasiPerJenisBelanja.php index bcc832b5..50501158 100644 --- a/app/Nova/Metrics/RealisasiPerJenisBelanja.php +++ b/app/Nova/Metrics/RealisasiPerJenisBelanja.php @@ -25,7 +25,7 @@ public function __construct() ]); $this->title('Target Serapan Anggaran Per Jenis Belanja Periode ini'); - $dipaId = Helper::getPropertyFromCollection(Dipa::cache()->get('all')->where('tahun', session('year'))->first(),'id'); + $dipaId = Helper::getPropertyFromCollection(Dipa::cache()->get('all')->where('tahun', session('year'))->first(), 'id'); $bulan = date('m'); $datas = DB::table('mata_anggarans') diff --git a/app/Nova/Metrics/RencanaPenarikanPerJenisBelanja.php b/app/Nova/Metrics/RencanaPenarikanPerJenisBelanja.php index fae173b2..7267af4f 100644 --- a/app/Nova/Metrics/RencanaPenarikanPerJenisBelanja.php +++ b/app/Nova/Metrics/RencanaPenarikanPerJenisBelanja.php @@ -23,7 +23,7 @@ public function __construct() ]); $this->title('Monitoring Rencana Penarikan Dana'); - $dipaId = Helper::getPropertyFromCollection(Dipa::cache()->get('all')->where('tahun', session('year'))->first(),'id'); + $dipaId = Helper::getPropertyFromCollection(Dipa::cache()->get('all')->where('tahun', session('year'))->first(), 'id'); $bulan = date('m'); $datas = DB::table('mata_anggarans') diff --git a/app/Nova/PembelianPersediaan.php b/app/Nova/PembelianPersediaan.php index a97f18ab..c473b4f6 100644 --- a/app/Nova/PembelianPersediaan.php +++ b/app/Nova/PembelianPersediaan.php @@ -231,7 +231,6 @@ public function actions(NovaRequest $request) ); } }); - } if (Policy::make()->allowedFor('bmn')->get()) { $actions[] = diff --git a/app/Nova/PermintaanPersediaan.php b/app/Nova/PermintaanPersediaan.php index be961c65..24b7f87a 100644 --- a/app/Nova/PermintaanPersediaan.php +++ b/app/Nova/PermintaanPersediaan.php @@ -204,7 +204,7 @@ public function actions(NovaRequest $request) public static function indexQuery(NovaRequest $request, $query) { $query->whereYear('tanggal_permintaan', session('year')); - if (!Policy::make()->allowedFor('bmn')->get()) { + if (! Policy::make()->allowedFor('bmn')->get()) { $query->where('user_id', $request->user()->id); } } diff --git a/app/Nova/User.php b/app/Nova/User.php index 82c909db..033c4d09 100644 --- a/app/Nova/User.php +++ b/app/Nova/User.php @@ -68,7 +68,7 @@ public function fields(NovaRequest $request) ->rules('required', 'regex:/^[0-9A-Za-z.\-_]+$/u', 'max:254') ->creationRules('unique:users,email') ->updateRules('unique:users,email,{{resourceId}}') - ->readonly(!Policy::make()->allowedFor('admin')->get()), + ->readonly(! Policy::make()->allowedFor('admin')->get()), Password::make('Password') ->onlyOnForms() ->creationRules('required', Rules\Password::defaults(), 'confirmed') diff --git a/app/Policies/BastMitraPolicy.php b/app/Policies/BastMitraPolicy.php index 1c250b3b..ed4a2cf4 100644 --- a/app/Policies/BastMitraPolicy.php +++ b/app/Policies/BastMitraPolicy.php @@ -14,7 +14,7 @@ class BastMitraPolicy */ public function viewAny(): bool { - return !Policy::make() + return ! Policy::make() ->allowedFor('admin') ->get(); } diff --git a/app/Policies/DaftarSp2dPolicy.php b/app/Policies/DaftarSp2dPolicy.php index 516135da..19343905 100644 --- a/app/Policies/DaftarSp2dPolicy.php +++ b/app/Policies/DaftarSp2dPolicy.php @@ -11,7 +11,7 @@ class DaftarSp2dPolicy */ public function viewAny(): bool { - return !Policy::make() + return ! Policy::make() ->allowedFor('admin') ->get(); } @@ -21,7 +21,7 @@ public function viewAny(): bool */ public function view(): bool { - return !Policy::make() + return ! Policy::make() ->allowedFor('admin') ->get(); } diff --git a/app/Policies/HonorKegiatanPolicy.php b/app/Policies/HonorKegiatanPolicy.php index 2ee05672..c8f93ee1 100644 --- a/app/Policies/HonorKegiatanPolicy.php +++ b/app/Policies/HonorKegiatanPolicy.php @@ -14,7 +14,7 @@ class HonorKegiatanPolicy */ public function viewAny(): bool { - return !Policy::make() + return ! Policy::make() ->allowedFor('admin') ->get(); } @@ -32,7 +32,7 @@ public function view(User $user, HonorKegiatan $honor): bool ->get(); } - return !Policy::make() + return ! Policy::make() ->allowedFor('admin') ->withYear($honor->tahun) ->get(); diff --git a/app/Policies/KontrakMitraPolicy.php b/app/Policies/KontrakMitraPolicy.php index 6a62e12c..d0ecb46e 100644 --- a/app/Policies/KontrakMitraPolicy.php +++ b/app/Policies/KontrakMitraPolicy.php @@ -13,7 +13,7 @@ class KontrakMitraPolicy */ public function viewAny(): bool { - return !Policy::make() + return ! Policy::make() ->allowedFor('admin') ->get(); } diff --git a/app/Policies/NaskahKeluarPolicy.php b/app/Policies/NaskahKeluarPolicy.php index 3ac06b2f..aa777e89 100644 --- a/app/Policies/NaskahKeluarPolicy.php +++ b/app/Policies/NaskahKeluarPolicy.php @@ -14,7 +14,7 @@ class NaskahKeluarPolicy */ public function viewAny(): bool { - return !Policy::make() + return ! Policy::make() ->allowedFor('admin') ->get(); } diff --git a/app/Policies/NaskahMasukPolicy.php b/app/Policies/NaskahMasukPolicy.php index e56fad60..a088e202 100644 --- a/app/Policies/NaskahMasukPolicy.php +++ b/app/Policies/NaskahMasukPolicy.php @@ -14,7 +14,7 @@ class NaskahMasukPolicy */ public function viewAny(): bool { - return !Policy::make() + return ! Policy::make() ->allowedFor('admin') ->get(); } diff --git a/app/Policies/RewardPegawaiPolicy.php b/app/Policies/RewardPegawaiPolicy.php index 41d8a845..0c5d5808 100644 --- a/app/Policies/RewardPegawaiPolicy.php +++ b/app/Policies/RewardPegawaiPolicy.php @@ -13,7 +13,7 @@ class RewardPegawaiPolicy */ public function viewAny(): bool { - return !Policy::make() + return ! Policy::make() ->allowedFor('admin') ->get(); }