New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `enqueue_#{column}_background_job?` to process in foreground #186

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@gdott9
Contributor

gdott9 commented Aug 12, 2014

Pull request #169 sets process_#{column}_upload = true when remove_#{column} is set, even if it is set to false.
In this case, the file will not be processed in a background process.

In this pull request, I use enqueue_#{column}_background_job? (which checks if the file is marked for removal) instead of process_#{column}_upload to check if it should be a background process or if carrierwave should handle the processing directly.

@gdott9

This comment has been minimized.

Show comment
Hide comment
@gdott9

gdott9 Mar 20, 2015

Contributor

Bump ? 👍

Contributor

gdott9 commented Mar 20, 2015

Bump ? 👍

@lardawge lardawge closed this Jan 3, 2016

@gdott9

This comment has been minimized.

Show comment
Hide comment
@gdott9

gdott9 Mar 8, 2016

Contributor

Hello,

I would like to know why you closed this pull request. Any specific reason ?
I still have a bug when remove_#{column} is set to false. And tell me if I am wrong but I think it makes sense to use enqueue_#{column}_background_job? to check if the upload has to be processed in background or not in these methods.

Contributor

gdott9 commented Mar 8, 2016

Hello,

I would like to know why you closed this pull request. Any specific reason ?
I still have a bug when remove_#{column} is set to false. And tell me if I am wrong but I think it makes sense to use enqueue_#{column}_background_job? to check if the upload has to be processed in background or not in these methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment