Ideas and fixes. #33

wants to merge 2 commits into


None yet
2 participants

iliya-gr commented Apr 2, 2012

  1. Added #{column} accessor for retrieving cached uploader.
  2. Carrierwave call's write_#{column}_identifier on save to clear column value if column was marked for removal (with remove_#{column}= or remove_#{column}! methods).
  3. Don't clear #{column}_tmp if no file was provided (it also fixes issue in mongoid that prevents deletion of embedded document).
  4. Check #{column}_tmp for presence and changes before enqueue background job.

lardawge commented Apr 2, 2012

These need to be split into separate pull requests and better documented. I have no idea what your fixing with either commit. "Fixes" tells me nothing. :)

lardawge closed this Apr 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment