Add sticky tab navigation #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a week preference on having less information/text on one site, therefore I would go with the persistent tab bar but the side bar as it is currently done. But as I said no strong preference. |
|
Agree with Maria, the sticky top bar is great but would keep left panel as it is now. |
|
OK, I'll take a look and see if I can figure it out how to make it work. |
|
I simplified the side navigation to not include the top level: |
lgeiger
force-pushed
the
docs-sticky-header
branch
from
490acb8
to
f265ecf
Compare
koenhelwegen
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used my rusty HTML/CSS skills, to play a bit with our documentation site:
This changes the top level navigation have a persistent tab bar:
One thing I am not sure about is if it is good to repeat the top-level navigation on the left sidebar or should we switch that back to how it is currently done in https://larq.dev/?