Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation of scoped metric definition #281

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@leonoverweel
Copy link
Contributor

leonoverweel commented Oct 8, 2019

Created top-level documentation for larq/metrics.py, explaining why we define the flip_ratio metric using a scope rather than passing it to the model at compile time. Based on pointers by @lgeiger.

Based on explanation by @lgeiger
@leonoverweel leonoverweel requested a review from larq/core Oct 8, 2019
@lgeiger
lgeiger approved these changes Oct 8, 2019
@lgeiger lgeiger merged commit 934b2f9 into master Oct 8, 2019
10 checks passed
10 checks passed
build
Details
tests (1.13.1)
Details
tests (1.14.0)
Details
tests (1.15.0-rc2)
Details
tests (2.0.0)
Details
coverage
Details
codecov/patch Coverage not affected when comparing 07b798e...85f4942
Details
codecov/project 95.15% remains the same compared to 07b798e
Details
now Deployment has completed
Details
pull_request_label All labels match
Details
@lgeiger lgeiger deleted the metrics-docs branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.