Add support for non-zero padding #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgeiger
commented
Feb 28, 2020
| @@ -181,6 +182,7 @@ def __init__( | |||
| kernel_size, | |||
| strides=1, | |||
| padding="valid", | |||
| pad_values=0.0, | |||
There was a problem hiding this comment.
@larq/core how do you feel about pad_values vs padding_values?
There was a problem hiding this comment.
I'm fine with either, no particular preference.
There was a problem hiding this comment.
From an initial look this LGTM, but given how complex it is I think another few sets of eyes would be useful. CC @Tombana, given your experience with padding, can you take a look?
lgeiger
commented
Feb 28, 2020
lgeiger
force-pushed
the
add-non-zero-padding
branch
2 times, most recently
from
a1f1522 to
2057892
Compare
Tombana
approved these changes
Mar 2, 2020
lgeiger
force-pushed
the
add-non-zero-padding
branch
from
2057892 to
c00da9b
Compare
koenhelwegen
approved these changes
Mar 11, 2020
Good point. I added a check to make sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for non zero padding for
QuantConv1D,QuantConv2D,QuantConv3D,QuantDepthwiseConv2D,QuantSeparableConv1DandQuantSeparableConv2Din order to better support larq/compute-engine#252We can add support for locally connected layers and transposed convolutions in the future.