Submodule versus npm #16

Closed
scunningham opened this Issue Mar 9, 2012 · 3 comments

Comments

Projects
None yet
2 participants

I'm pretty new to node, but was wondering why jasmine-reporters uses a submodule instead of package dependency? Makes the library difficult if you need to bring the source code in house for code-reproducibility issues. Submodules force a hard link to an external resource, which may or may not be available.

Thanks,
Sean

Collaborator

bloveridge commented Mar 9, 2012

  1. jasmine-reporters was not originally a node package
  2. the included submodule is not a dependency for using jasmine-reporters
    • the submodule allows you an alternative way of running the specs (specs can now run via PhantomJS or Rhino or Node)
  3. I actually removed the submodule and dependency on the library it included even for running tests via PhantomJS last night, I just didn't tag or do a new release
    • I will happily do so

bloveridge closed this Mar 9, 2012

Collaborator

bloveridge commented Mar 9, 2012

0.2.1 has been tagged and pushed to npm

Very much appreciated. I wish my co-workers were as responsive.

On Fri, Mar 9, 2012 at 5:01 PM, Ben Loveridge
reply@reply.github.com
wrote:

0.2.1 has been tagged and pushed to npm


Reply to this email directly or view it on GitHub:
#16 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment