New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it fails for Wikidata entries with "author" fields #19

Closed
egonw opened this Issue Dec 30, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@egonw
Contributor

egonw commented Dec 30, 2016

E.g. for https://www.wikidata.org/wiki/Q27795847 where it fails with this message:

Uncaught TypeError: str.split is not a function
    at parseName (https://larsgw.github.io/citation.js/src/citation-0.2.js:415:19)
    at https://larsgw.github.io/citation.js/src/citation-0.2.js:1014:54
    at Array.map (native)
    at parseWikidataProp (https://larsgw.github.io/citation.js/src/citation-0.2.js:1014:22)
    at parseWikidataJSON (https://larsgw.github.io/citation.js/src/citation-0.2.js:1179:18)
    at parseInputData (https://larsgw.github.io/citation.js/src/citation-0.2.js:1793:16)
    at parseInput (https://larsgw.github.io/citation.js/src/citation-0.2.js:1835:14)
    at parseInputData (https://larsgw.github.io/citation.js/src/citation-0.2.js:1765:16)
    at parseInput (https://larsgw.github.io/citation.js/src/citation-0.2.js:1835:14)
    at Cite.add (https://larsgw.github.io/citation.js/src/citation-0.2.js:2176:17)

@larsgw larsgw self-assigned this Dec 30, 2016

@larsgw larsgw added the bug label Dec 30, 2016

@larsgw

This comment has been minimized.

Show comment
Hide comment
@larsgw

larsgw Dec 30, 2016

Owner

Apparently, I didn't run enough tests after adding the P50 property. It will be fixed in v0.2.12 and appropriate tests will be added in the same version or in v0.3, as there is a test case shortage (#22)

Owner

larsgw commented Dec 30, 2016

Apparently, I didn't run enough tests after adding the P50 property. It will be fixed in v0.2.12 and appropriate tests will be added in the same version or in v0.3, as there is a test case shortage (#22)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment