Skip to content
Permalink
Browse files

Minor lint updates (#2766)

* remove some double space

* update abaplint to latest

* fixes
  • Loading branch information...
larshp committed Jul 2, 2019
1 parent df0aca8 commit c84b2099447d8d9b26e42b04b6fd0111e932bbb7
@@ -49,7 +49,7 @@
"constructor_visibility_public": {
"enabled": true,
"exclude": []
},
},
"contains_tab": {
"enabled": true,
"exclude": []
@@ -63,23 +63,32 @@
"exclude": []
},
"double_space": {
"enabled": true,
"exclude": []
"enabled": false,
"exclude": [],
"keywords": true,
"startParen": true,
"endParen": true
},
"empty_line_in_statement": {
"enabled": true,
"exclude": [],
"allowChained": true
},
"empty_loop": {
"enabled": true,
"exclude": [],
"length": 120
},
"empty_statement": {
"enabled": true,
"exclude": []
},
"empty_structure": {
"enabled": true,
"exclude": [],
"loop": true,
"if": false,
"while": true,
"case": true,
"select": true,
"do": true,
"at": true
},
"exit_or_check": {
"enabled": true,
"exclude": []
@@ -105,6 +114,11 @@
"enabled": true,
"exclude": []
},
"in_statement_indentation": {
"enabled": false,
"exclude": [],
"ignoreExceptions": true
},
"indentation": {
"enabled": true,
"exclude": [],
@@ -258,6 +272,12 @@
"enabled": true,
"exclude": []
},
"space_before_dot": {
"enabled": true,
"exclude": [],
"ignoreGlobalDefinition": true,
"ignoreExceptions": true
},
"start_at_tab": {
"enabled": true,
"exclude": []
@@ -274,6 +294,10 @@
"enabled": true,
"exclude": []
},
"use_new": {
"enabled": true,
"exclude": []
},
"when_others_last": {
"enabled": true,
"exclude": []
@@ -92,7 +92,7 @@ CLASS ZCL_ABAPGIT_2FA_AUTH_BASE IMPLEMENTATION.
url = iv_url
ssl_id = zcl_abapgit_exit=>get_instance( )->get_ssl_id( )
proxy_host = lo_proxy->get_proxy_url( iv_url )
proxy_service = lo_proxy->get_proxy_port( iv_url )
proxy_service = lo_proxy->get_proxy_port( iv_url )
IMPORTING
client = ri_client
EXCEPTIONS
@@ -82,7 +82,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SFPF IMPLEMENTATION.
* Renumber id='o...' attributes
li_iterator = ii_document->create_iterator_filtered(
ii_document->create_filter_and(
filter1 = ii_document->create_filter_node_type( if_ixml_node=>co_node_element )
filter1 = ii_document->create_filter_node_type( if_ixml_node=>co_node_element )
filter2 = ii_document->create_filter_attribute( 'id' ) ) ).
li_elem ?= li_iterator->get_next( ).
WHILE li_elem IS NOT INITIAL.
@@ -56,7 +56,7 @@ CLASS ltcl_abapgit_gui_asset_manager IMPLEMENTATION.
iv_assert_subtype = 'css' )
exp = 'ABC' ).

TRY .
TRY.
lo_assetman->zif_abapgit_gui_asset_manager~get_text_asset(
iv_url = 'css/common.css'
iv_assert_subtype = 'xyz' ).
@@ -70,7 +70,7 @@ CLASS ltcl_abapgit_gui_asset_manager IMPLEMENTATION.
iv_type = 'nottext/bin'
iv_inline = 'XYZ' ).

TRY .
TRY.
lo_assetman->zif_abapgit_gui_asset_manager~get_text_asset( 'css/common.xyz' ).
cl_abap_unit_assert=>fail( ).
CATCH zcx_abapgit_exception.
@@ -160,7 +160,7 @@ CLASS ltcl_html_processor_test IMPLEMENTATION.

METHOD process_fails.

TRY .
TRY.
" BTW this is valid HTML, maybe refactor the code ...
mo_cut->zif_abapgit_gui_html_processor~process(
iv_html = '<html><body></body></html>'
@@ -322,7 +322,7 @@ CLASS ZCL_ABAPGIT_SERVICES_REPO IMPLEMENTATION.
ls_checks = lo_repo->delete_checks( ).
IF ls_checks-transport-required = abap_true.
ls_checks-transport-transport = zcl_abapgit_ui_factory=>get_popups(
)->popup_transport_request( ls_checks-transport-type ).
)->popup_transport_request( ls_checks-transport-type ).
ENDIF.

zcl_abapgit_repo_srv=>get_instance( )->purge( io_repo = lo_repo
@@ -50,7 +50,7 @@ CLASS ZCL_ABAPGIT_TRANSPORT_MASS IMPLEMENTATION.
iv_logic = zcl_abapgit_ui_factory=>get_popups( )->popup_folder_logic( ) ).

* Open output folder if user asked it
lcl_gui=>open_folder_frontend( lo_transport_zipper->gv_full_folder ).
lcl_gui=>open_folder_frontend( lo_transport_zipper->gv_full_folder ).

ELSE.
* No data found for the provided selection criterias

0 comments on commit c84b209

Please sign in to comment.
You can’t perform that action at this time.