New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVAS Classification #1360

Open
larshp opened this Issue May 8, 2018 · 5 comments

Comments

2 participants
@larshp
Owner

larshp commented May 8, 2018

Serialization and deserialization for AVAS Classification

package SPAK_TOOL_CLASSIFICATION?

@larshp

This comment has been minimized.

Owner

larshp commented Jun 17, 2018

can probably be done with class CL_CLS_ATTR_VALUE_ASSIGNMENT, similar to #1513

@jfilak

This comment has been minimized.

jfilak commented Jun 18, 2018

The SOBJ serialization (abapGit-plugins) for AVAS objects work well, only the deserialization does not write TADIR.

@jfilak

This comment has been minimized.

jfilak commented Jun 18, 2018

Also the key should not be the uuid because it is subject to change. I think the uuid can be ignored, because in our landscape we sometimes need to "re-create" an AVAS object for an report in an older releases - so it gets a new uuid, which is overwritten during the next upgrade.

@larshp

This comment has been minimized.

Owner

larshp commented Jun 18, 2018

I would like to deprecate abapGit-plugins, as it is not really clear if it works or not. In this case the TADIR entry is missing.

Moving it to a real object makes sure it is tested, and we can do fixes for it.

Also see #1449

@larshp larshp self-assigned this Jul 10, 2018

larshp added a commit that referenced this issue Jul 10, 2018

@larshp larshp referenced this issue Jul 10, 2018

Merged

AVAS support #1609

larshp added a commit that referenced this issue Jul 12, 2018

AVAS support (#1609)
* AVAS #1360

* AVAS support

* fix linter errors
@larshp

This comment has been minimized.

Owner

larshp commented Jul 12, 2018

Future actions/questions:

  • AVAS stores the name of the DEVC objects, but in abapGit it does not necessarily have the same name. Perhaps assume that DEVC classifications are always in the package, as LOCAL and HOME objects will never be serialized in abapGit
  • I'm not sure how Linked Objects works in SCLAS, so this has not been implemented

@larshp larshp removed their assignment Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment