Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint #2240

Merged
merged 2 commits into from Dec 30, 2018

Conversation

Projects
None yet
2 participants
@sbcgua
Copy link
Collaborator

commented Dec 29, 2018

to #2232
@larshp @christianguenter2

  • decided to leave double quotes, as most of the code use them
  • fixed liner suggestions, except no-unused-vars for most of functions - they are called from SAP so eslint does not know about that. I guess that maybe the rule can be disabled ... though it is useful ... or put pragmas everywhere (15 cases)
  • probably would be a good idea to add this to travis (and refactor travis config in general ... e.g. keeping the token code there is very insecure)

sbcgua added some commits Dec 27, 2018

@larshp

This comment has been minimized.

Copy link
Owner

commented Dec 29, 2018

this token code: https://github.com/larshp/abapGit/blob/master/.travis.yml#L14 ? its encrypted, anyhow if its a problem suggest opening separate issue for it

@larshp larshp merged commit ceb7a6d into larshp:master Dec 30, 2018

2 checks passed

abaplint Summary
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sbcgua sbcgua deleted the sbcgua:eslint branch Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.