Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline icons #2454

Merged
merged 12 commits into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@sbcgua
Copy link
Collaborator

commented Feb 24, 2019

to #2450

For review

Yet todo:

  • minor CSS tunings
  • mention font licenses somewhere (see question in #2450)
  • update abapmerge (base64 include is not supported, config is not included so may result in error)

@sbcgua sbcgua marked this pull request as ready for review Mar 3, 2019

@sbcgua

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 3, 2019

I guess ready for review and merge now
see added docs for the procedure by the way.

@sbcgua

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 3, 2019

to remind: the new abapmerge is needed to build after this PR

@larshp

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2019

I'd like the code to be PR'ed to https://github.com/abapGit/icon-font, but I guess it will also work without

@larshp larshp merged commit c03bb68 into larshp:master Mar 6, 2019

2 checks passed

abaplint Summary
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@larshp larshp referenced this pull request Mar 12, 2019

Closed

abapGit UI hangs sometimes #2415

@sbcgua sbcgua deleted the sbcgua:icons branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.