Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added client check to add the ability to run abapGit in production/QA environments #2668

Merged
merged 4 commits into from May 15, 2019

Conversation

Projects
None yet
2 participants
@Srinu3366
Copy link
Contributor

commented May 13, 2019

Check if repository objects are modifiable in client. If not make write_protected setting active for all repos and make this setting disabled in repo setting page. This will not change this setting in ABAPGit database table.

Issue #2611

Srinu3366 added some commits May 13, 2019

Added client check
Check if repository objects are modifiable in client. If not make write_protected setting active for all repos and make this setting disabled in repo setting page.
fix abaplint errors
fix for abaplint errors
@larshp

This comment has been minimized.

Copy link
Owner

commented May 13, 2019

cool, suggest adding the new method in class https://github.com/larshp/abapGit/blob/master/src/zcl_abapgit_environment.clas.abap instead of introducing a new class

Srinu3366 added some commits May 13, 2019

code changes as suggested in review
1) Remove zcl_abapgit_client_check class
2) Add is_repo_object_changes_allowed method to zcl_abapgit_environment class
Delete zcl_abapgit_client_check class
Delete zcl_abapgit_client_check class
@Srinu3366

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

Done the changes as suggested. Removed the new class and added code to class zcl_abapgit_environment.

Now the changes include

  1. New method is_repo_object_changes_allowed in class zcl_abapgit_environment
  2. Irrespective of saved settings enable write_protected in zcl_abapgit_persistence_repo if repository objects changes not allowed in the client.
  3. Disable the option to change write_protected in repo settings in class zcl_abapgit_gui_page_repo_sett if repository objects changes not allowed in the client.
  4. Remove the client check in ABAPGit main program include ZABAPGIT_FORMS
@larshp

larshp approved these changes May 14, 2019

Copy link
Owner

left a comment

LGTM

@larshp larshp merged commit d1c5e33 into larshp:master May 15, 2019

2 checks passed

abaplint Summary
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Srinu3366 Srinu3366 deleted the Srinu3366:issue-2611 branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.