Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display contribution guidelines more prominently #2728

Merged
merged 5 commits into from Jun 7, 2019

Conversation

Projects
None yet
2 participants
@FreHu
Copy link
Collaborator

commented Jun 6, 2019

#2726 Moved from deep inside the documentation. I also changed the wording a bit to make it more motivational.

@FreHu FreHu requested a review from larshp Jun 6, 2019

@larshp

This comment has been minimized.

Copy link
Owner

commented Jun 7, 2019

I would like to keep the README as short as possible, suggest adding a very short text with a link to more information.

also consider if https://github.com/larshp/abapGit/blob/master/CONTRIBUTING.md should be referenced/refactored

@FreHu

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 7, 2019

I didn't notice the file, it wasn't linked to from anywhere. I will move the stuff from the readme there and link it.

@larshp

This comment has been minimized.

Copy link
Owner

commented Jun 7, 2019

The GitHub platform shows a link to the CONTRIBUTING file, eg when opening issues and PRs, https://help.github.com/en/articles/setting-guidelines-for-repository-contributors

FreHu and others added some commits Jun 7, 2019

@larshp

This comment has been minimized.

Copy link
Owner

commented Jun 7, 2019

fixed a few minor things

should we still delete most of the text in docs/collections/_development/guidelines.md ? I think we should at least link to CONTRIBUTING from the document

@larshp

larshp approved these changes Jun 7, 2019

Copy link
Owner

left a comment

LGTM

@FreHu FreHu merged commit 6a25e45 into larshp:master Jun 7, 2019

2 checks passed

abaplint Summary
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.