Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert behavior of second back button #2779

Merged
merged 3 commits into from Jul 11, 2019

Conversation

Projects
None yet
4 participants
@FreHu
Copy link
Collaborator

commented Jul 9, 2019

This only reverts #2679. I'm going to leave the buttons be.

As discussed on Slack, the three buttons are not consistent across themes, so what works in some may be strange in others.

image

@FreHu FreHu requested a review from flaiker Jul 9, 2019

@sbcgua

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

I'd leave CLEAR mt_stack. - this was a bug fix in fact.
P.S. pity about inconsistency, the idea was actually not bad.

@flaiker
Copy link
Collaborator

left a comment

👍

@flaiker

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

Sorry for breaking this feature by the way :/

@larshp larshp merged commit 7774450 into larshp:master Jul 11, 2019

2 checks passed

abaplint Summary
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.