Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC enabled Code Inspector checks #422

Closed
se38 opened this issue Sep 20, 2017 · 9 comments
Closed

RFC enabled Code Inspector checks #422

se38 opened this issue Sep 20, 2017 · 9 comments

Comments

@se38
Copy link
Contributor

se38 commented Sep 20, 2017

Hello Lars,
currently I'm implementing a central ATC landscape (central ATC server with 7.51 and satellite DEV systems).
To use Code Inspector checks in such a landscape, the checks have to be RFC-enabled (see https://blogs.sap.com/2017/02/27/remote-code-analysis-in-atc-for-developers/ ).

Do you know already how to RFC-enable the abapOpenChecks? Or should we ask Thomas Fiedler?
If you publish a How-To on the wiki page, I'd help you to RFC-enable the checks one-by-one.

Cheers, Uwe (aka @se38)

@larshp
Copy link
Owner

larshp commented Sep 20, 2017

Hi,
I looked into it a while ago, see #336

Somewhere there is a restriction that only static checks are executed remotely, however I'm not sure what it means, and dont remember much about it.

@se38
Copy link
Contributor Author

se38 commented Sep 20, 2017

Don't have any idea neither. If you look in a 7.51 system (ie the developer edition) you can identify the RFC-enabled check by the flash.
atc
I asked alredy on SCN and will report back, as soon as I get an answer:. https://blogs.sap.com/2017/02/27/remote-code-analysis-in-atc-for-developers/#comment-391832

@larshp
Copy link
Owner

larshp commented Sep 20, 2017

setting REMOTE_RFC_ENABLED = ABAP_TRUE in the constructor, and the icon shows up. However I get a strange dump in CL_ABAP_COMP_PROCS_E, but I'm also trying to setup central checks using just 1 system. UPDATE: after running program RS_ABAP_INIT_ANALYSIS I now get a proper dump in the abapOpenChecks code.

Note that check 04 is very simple, so it might be the easiest to get working first, plus it only uses scan information.

btw, the magic function module that runs the remote checks is SCI_REMOTE_RUN

image

image

@larshp
Copy link
Owner

larshp commented Sep 20, 2017

try this: #423

@se38
Copy link
Contributor Author

se38 commented Sep 21, 2017

Ha, you made it (again). This fix works. Here's the (RFC!) result for Check #11 :
atc

Just one Q:
What's the reason you want to ASSIGN the variable in the constructor? "remote_rfc_enabled = abap_true." simply works also.

@larshp
Copy link
Owner

larshp commented Sep 21, 2017

I have merged the branch.

ASSIGN: I assume the field does not exist in version 702, abapOpenChecks is targeted 702 and higher.

Feel free to open a PR with additional fixes, note that some of the checks uses more than just the code scan information, if in doubt add as a separate PR and I will have a look. Also, I would like to move the code for setting RFC enabled to a method in ZCL_AOC_SUPER

ASSIGN ('REMOTE_RFC_ENABLED') TO <lv_rfc>.
IF sy-subrc = 0.
  <lv_rfc> = abap_true.
ENDIF.

larshp added a commit that referenced this issue Sep 21, 2017
larshp added a commit that referenced this issue Sep 21, 2017
@larshp
Copy link
Owner

larshp commented Sep 21, 2017

Hi,
I have enabled more checks now, these are the ones I think will work via RFC, but I have not tested them

@se38
Copy link
Contributor Author

se38 commented Sep 22, 2017

I've checked some of the new RFC-enabled checks -> perfect, gracias

@se38 se38 closed this as completed Sep 22, 2017
@larshp
Copy link
Owner

larshp commented Jan 7, 2018

now also shown in the documentation, http://docs.abapopenchecks.org/checks/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants