Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No `Vary: Origin` #1

Closed
obscaenvs opened this issue Sep 11, 2015 · 1 comment
Closed

No `Vary: Origin` #1

obscaenvs opened this issue Sep 11, 2015 · 1 comment

Comments

@obscaenvs
Copy link

@obscaenvs obscaenvs commented Sep 11, 2015

I have set corsVaryOrigin to True, as below, but I get no Vary: Origin in the response from the server. Fix for now for me is to set this header using WAI middleware.

corsPolicy :: CorsResourcePolicy
corsPolicy = CorsResourcePolicy
                    {
                      corsOrigins = Just (["http://example.com"], False)
                    , corsMethods = ["POST"]
                    , corsRequestHeaders = []
                    , corsExposedHeaders = Nothing
                    , corsMaxAge = Nothing
                    , corsVaryOrigin = True
                    , corsRequireOrigin = True
                    , corsIgnoreFailures = False
                    }
@larskuhtz larskuhtz mentioned this issue Nov 5, 2015
3 of 3 tasks complete
larskuhtz added a commit that referenced this issue Nov 6, 2015
Issue #1: missing vary origin header
@larskuhtz

This comment has been minimized.

Copy link
Owner

@larskuhtz larskuhtz commented Nov 6, 2015

Thanks for the bug report and my apologies that it took me so long to reply to it. The issue got fixed in PR #2. It will be included in version 0.2.4 which I am planning to release soon.

@larskuhtz larskuhtz closed this Nov 6, 2015
larskuhtz pushed a commit that referenced this issue Aug 28, 2017
Fix spelling error through rewording of paragraph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.