Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vote count field to NewsItem, Issue and Comment models. #334

Merged
merged 1 commit into from Jun 1, 2014
Merged

Add vote count field to NewsItem, Issue and Comment models. #334

merged 1 commit into from Jun 1, 2014

Conversation

ghost
Copy link

@ghost ghost commented Apr 27, 2014

This pull request increments a vote_count field on NewsItems, Comments and Issues as votes are saved. The idea is to eliminate the need to calculate votes for these items when calculating scores which should greatly improve the performance problems indicated in issue #328 while retaining the ability to dynamically calculate scores.

Note that this is only the first step in this proposed solution, and on it's own only begins to aggregate the vote counts for new items. Should we decide to fully implement this we would next need to calculate the vote counts for all existing items and only then could we refine the selection/scoring process to use these new values (as stated in the comments for Issue #328)

@ghost ghost mentioned this pull request May 6, 2014
@megamattron
Copy link
Member

Should I merge this now or are we waiting until step 2 is ready to go?

@ghost
Copy link
Author

ghost commented May 12, 2014

I think this is ready to commit with the caveat noted above.

Unfortunately, the conversation on #328 seemes to have stalled... In keeping with the "community-built site" theme I've suggested these three smaller steps (this implements the first of those), hoping others would chime in on the other parts.

If you do apply this we should open a new issue for the data alignment part, and once that's implemented refactoring the scoring code should be fairly simple.

@josephwegner
Copy link
Collaborator

@megamattron Can you merge this?

megamattron added a commit that referenced this pull request Jun 1, 2014
Add vote count field to NewsItem, Issue and Comment models.
@megamattron megamattron merged commit f1e123b into larvalabs:master Jun 1, 2014
@megamattron
Copy link
Member

Sorry it took me so long, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants