Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Redis 4.x missing req/res commands #19

sirocchj opened this issue Aug 8, 2018 · 3 comments


Copy link

commented Aug 8, 2018

Most should be highlighted by FIXME and/or TODO in code


This comment has been minimized.

Copy link
Member Author

commented Dec 5, 2018

Working on this, will open a PR soon

@sirocchj sirocchj self-assigned this Feb 28, 2019

sirocchj added a commit that referenced this issue Aug 10, 2019

Partial fix for #19 (#75)
* - migrate cmd

* - add contramap to Show, reformat implicitNotFound msg

* - RESPParamWrite reformat implicitNotFound msg, reorg instances classes

* - LowPriorityShowInstances -> ShowInstances and make sealed an package private

* - ops revert to using traits for init order

* - Read: modify implicitNotFound msg, replaced zip (unused and unneeded) with orElse (a bit more useful), combinators leverage Read constructors

* - echo and ping now accept any A: Show, also require NonNullBulkString ==> A evidence

* - reworded implicitNotFound msg, use widenLeft where appropriate

* more fixes

* - remove unneeded lazy vals in build.sbt for cross build components
- add comment on why we shadow scala.js plugin

* - toShowSyntax -> toShowOps

* - address codacy issues

* fixed compilation issue w/ scalatest 3.0.6

* wip geo

* Ignoring metals+bloom directories

* refactor Read instances names and grouping

* Fixed benchmarks compilation issues

* remove explicit evidence when not needed

* mostly code formatting

* more formatting

* refactor all RESP ADTs

* widen renamed to coerce where appropriate, more use of context bounds

* shuffling things around

* more cleanup, wip 2.11 broken

* more tests

* fixing 2.11 stack overflow in tests

* formatting

* more cleanup

* BaseSpec in core + must => should

* no implicit macro

* adding transation watch/unwatch

* cluster protocol commands

* testing more refined types

* completed tests on laserdisc-defined refined types

* polishing up

* removed manual refinements via refined API

* removed unuseful RESPBuilder and made Arr a wrapper on List[RESP] instead of Vector[RESP]

* no Show syntax, let Bulk handle Show

* renamed Extra to Ext(ended) and added a few tests

* roundtrip not round-trip

* nodes, finally

* bye bye 2.11

* minor README fix

* more ClusterP testing

* add cluster nodes test

* cleaning up tests

* fixed Host's RFC1123 hostname regex for JS

* cluster cleanup

* cluster cleanup - removed unnecessary parenthesis

* more on geo protocol

* completed geo protocol + tests

* wip on hash and key protocols

* removed last bit of 2.11/2.12 dichotomy

* minor cosmetics around geo protocol spec

* more hash tests

* added glob pattern generator + test and completed hash protocol spec

* wip key protocol

* still wip key protocol testing

* key protocol still missing SORT combinations

* added list protocol tests

* bump scalacheck to 1.14.0

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2019

What's missing (may not be exhaustive):

  • Scripting protocol
  • Tests for PublishP, ServerP, SetP, SortedSetP, StringP and TransactionP
  • Some FIXME and command combinations missing

This comment has been minimized.

Copy link

commented Aug 10, 2019

how about separate tickets ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.