Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scala 2.13, updated versions #130

Merged
merged 9 commits into from Sep 6, 2019

Conversation

@barambani
Copy link
Member

commented Sep 1, 2019

Closes #129.

A lot of snapshots, so let's wait before releasing, what do you thing ?

@barambani barambani requested a review from sirocchj Sep 1, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Sep 1, 2019

Codecov Report

Merging #130 into master will decrease coverage by 0.26%.
The diff coverage is 30.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   61.46%   61.19%   -0.27%     
==========================================
  Files          36       36              
  Lines        1199     1201       +2     
  Branches       12        5       -7     
==========================================
- Hits          737      735       -2     
- Misses        462      466       +4
Impacted Files Coverage Δ
core/src/main/scala/laserdisc/protocol/RESP.scala 85.71% <ø> (ø) ⬆️
cli/src/main/scala/laserdisc/cli/CLI.scala 0% <0%> (ø) ⬆️
fs2/src/main/scala/laserdisc/fs2/MkResource.scala 0% <0%> (-63.64%) ⬇️
...re/src/main/scala/laserdisc/protocol/ServerP.scala 0% <0%> (ø) ⬆️
...src/main/scala/laserdisc/fs2/RedisConnection.scala 73.68% <100%> (+1.46%) ⬆️
...2/src/main/scala/laserdisc/fs2/PromiseMapper.scala 100% <100%> (ø) ⬆️
fs2/src/main/scala/laserdisc/fs2/RedisClient.scala 68.49% <100%> (+0.88%) ⬆️
...e/src/main/scala/laserdisc/protocol/Protocol.scala 95% <100%> (ø) ⬆️
core/src/main/scala/laserdisc/laserdisc.scala 64.7% <55.55%> (-5.3%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa61f0d...9403781. Read the comment docs.

barambani and others added 7 commits Sep 1, 2019
@sirocchj
Copy link
Member

left a comment

Splendid! 👍🏻👍🏻👍🏻

@barambani barambani merged commit 5c69098 into laserdisc-io:master Sep 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@barambani barambani deleted the barambani:issue-129 branch Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.