Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced kind projector's ? with *. Added formatting alias #135

Merged
merged 1 commit into from Sep 7, 2019

Conversation

@barambani
Copy link
Member

commented Sep 6, 2019

No description provided.

@barambani barambani requested a review from sirocchj Sep 6, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Sep 7, 2019

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is 38.09%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   61.28%   61.28%           
=======================================
  Files          36       36           
  Lines        1201     1201           
  Branches        5        5           
=======================================
  Hits          736      736           
  Misses        465      465
Impacted Files Coverage Δ
...src/main/scala/laserdisc/protocol/SortedSetP.scala 0% <ø> (ø) ⬆️
...src/main/scala/laserdisc/fs2/RedisConnection.scala 73.68% <ø> (-5.27%) ⬇️
...ore/src/main/scala/laserdisc/protocol/BListP.scala 100% <ø> (ø) ⬆️
core/src/main/scala/laserdisc/protocol/SetP.scala 0% <0%> (ø) ⬆️
core/src/main/scala/laserdisc/laserdisc.scala 64.7% <0%> (ø) ⬆️
core/src/main/scala/laserdisc/protocol/KeyP.scala 92.68% <0%> (+1.21%) ⬆️
core/src/main/scala/laserdisc/protocol/Read.scala 76.28% <100%> (ø) ⬆️
...rc/main/scala/laserdisc/protocol/ConnectionP.scala 100% <100%> (ø) ⬆️
core/src/main/scala/laserdisc/protocol/HashP.scala 100% <100%> (ø) ⬆️
core/src/main/scala/laserdisc/protocol/ListP.scala 95% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c69098...2668713. Read the comment docs.

@sirocchj
Copy link
Member

left a comment

You beat me to it! Great, thanks!!

@sirocchj sirocchj merged commit bccc5a7 into laserdisc-io:master Sep 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@barambani barambani deleted the barambani:kind-projector-depr branch Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.