Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More ergonomics #141

Merged
merged 8 commits into from Sep 18, 2019

Conversation

@sirocchj
Copy link
Member

commented Sep 13, 2019

No description provided.

sirocchj added 2 commits Sep 12, 2019
…nd ergonomics (arities boilerplate gen), minor rework on fs2 test
@sirocchj sirocchj requested a review from barambani Sep 13, 2019
sirocchj added 4 commits Sep 13, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Sep 16, 2019

Codecov Report

Merging #141 into master will increase coverage by 0.28%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   61.14%   61.42%   +0.28%     
==========================================
  Files          36       36              
  Lines        1202     1203       +1     
  Branches        4        8       +4     
==========================================
+ Hits          735      739       +4     
+ Misses        467      464       -3
Impacted Files Coverage Δ
...src/main/scala/laserdisc/fs2/RedisConnection.scala 73.68% <ø> (ø) ⬆️
cli/src/main/scala/laserdisc/cli/CLI.scala 0% <0%> (ø) ⬆️
fs2/src/main/scala/laserdisc/fs2/RedisClient.scala 73.13% <100%> (+5.56%) ⬆️
fs2/src/main/scala/laserdisc/fs2/fs2.scala 100% <100%> (ø) ⬆️
...2/src/main/scala/laserdisc/fs2/PromiseMapper.scala 100% <100%> (ø) ⬆️
core/src/main/scala/laserdisc/client.scala 50% <50%> (ø)
core/src/main/scala/laserdisc/protocol/KeyP.scala 92.68% <0%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c6f1b...8437ff3. Read the comment docs.

sirocchj added 2 commits Sep 17, 2019
@sirocchj sirocchj merged commit 72b0503 into laserdisc-io:master Sep 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sirocchj sirocchj deleted the sirocchj:more-ergonomics branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.