Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified README to cater for log-effect + licence badge #23

Merged
merged 1 commit into from Aug 8, 2018
Merged

modified README to cater for log-effect + licence badge #23

merged 1 commit into from Aug 8, 2018

Conversation

sirocchj
Copy link
Member

@sirocchj sirocchj commented Aug 8, 2018

No description provided.

@sirocchj sirocchj requested a review from barambani August 8, 2018 09:10
barambani
barambani approved these changes Aug 8, 2018
View reviewed changes
Copy link
Member

@barambani barambani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. One thing I noticed about the badges is that scaladex updates very slowly when some version changes. In the future it might be worth considering maven central for the version badges. It's way more reactive to releases.

@sirocchj
Copy link
Member Author

sirocchj commented Aug 8, 2018

@barambani yeah, noticed that too. I'm ok switching

@barambani
Copy link
Member

Ok, another PR. 👍

@sirocchj sirocchj merged commit 4dc114e into laserdisc-io:master Aug 8, 2018
@sirocchj sirocchj deleted the fix-readme branch August 8, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barambani barambani barambani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sirocchj @barambani