Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix for #19 #75

Merged
merged 83 commits into from Aug 10, 2019

Conversation

@sirocchj
Copy link
Member

commented Jan 7, 2019

@barambani feel free to take a stab at reviewing it.

Here's a list of what's missing (may not be exhaustive):

  • Scripting & Streams protocol
  • Tests for PublishP, ServerP, SetP, SortedSetP, StringP and TransactionP
  • Some FIXME and command combinations missing
@codecov-io

This comment has been minimized.

Copy link

commented Jan 7, 2019

Codecov Report

Merging #75 into master will increase coverage by 24.27%.
The diff coverage is 69.03%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #75       +/-   ##
===========================================
+ Coverage   37.27%   61.55%   +24.27%     
===========================================
  Files          32       36        +4     
  Lines         947     1199      +252     
  Branches       10       11        +1     
===========================================
+ Hits          353      738      +385     
+ Misses        594      461      -133
Impacted Files Coverage Δ
fs2/src/main/scala/laserdisc/fs2/fs2.scala 100% <ø> (ø)
fs2/src/main/scala/laserdisc/fs2/RedisClient.scala 68.57% <ø> (ø) ⬆️
...src/main/scala/laserdisc/fs2/ProtocolHandler.scala 100% <ø> (ø) ⬆️
.../scala/laserdisc/protocol/LenientStringCodec.scala 50% <ø> (ø) ⬆️
fs2/src/main/scala/laserdisc/fs2/Request.scala 100% <ø> (ø) ⬆️
...src/main/scala/laserdisc/protocol/SortedSetP.scala 0% <0%> (ø) ⬆️
...re/src/main/scala/laserdisc/protocol/ServerP.scala 0% <0%> (ø) ⬆️
cli/src/main/scala/laserdisc/cli/CLI.scala 0% <0%> (ø) ⬆️
core/src/main/scala/laserdisc/protocol/SetP.scala 0% <0%> (ø) ⬆️
...e/src/main/scala/laserdisc/protocol/PublishP.scala 0% <0%> (ø) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45902bc...2017664. Read the comment docs.

- remove unneeded lazy vals in build.sbt for cross build components
- add comment on why we shadow scala.js plugin
@sirocchj sirocchj referenced this pull request Jan 11, 2019

@sirocchj sirocchj changed the title WIP - fixes #19 Partial fix for #19 Aug 6, 2019

@sirocchj sirocchj merged commit d530ae7 into laserdisc-io:master Aug 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sirocchj

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2019

That was easy lol

@sirocchj sirocchj deleted the sirocchj:fix-19 branch Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.