New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch alias_method_chain to Module#prepend #66

Merged
merged 1 commit into from Jul 4, 2016

Conversation

Projects
None yet
4 participants
@craig1410
Contributor

craig1410 commented Jan 18, 2016

Fixes #65

Not sure how I could DRY the two variants of the code without making it less easy to understand. Suggestions welcome. Maybe dropping Ruby 1.9 support in future is an option.

Switch alias_method_chain to Module#prepend
Added Ruby 2.2.0 to the travis build
@Jonjoe

This comment has been minimized.

Show comment
Hide comment
@Jonjoe

Jonjoe Apr 15, 2016

Can we please get this merged? Kinda annoying having dep warnings :P Thanks <3.

:shipit:

Jonjoe commented Apr 15, 2016

Can we please get this merged? Kinda annoying having dep warnings :P Thanks <3.

:shipit:

@jtrost

This comment has been minimized.

Show comment
Hide comment
@jtrost

jtrost May 3, 2016

The master branch has not been updated in two and a half years, so chances are this won't be merged in anytime soon. For now, I put this in my Gemfile to get rid of the deprecation warnings.

gem 'gretel', github: 'craig1410/gretel', branch: 'dep_alias_method_chain'

jtrost commented May 3, 2016

The master branch has not been updated in two and a half years, so chances are this won't be merged in anytime soon. For now, I put this in my Gemfile to get rid of the deprecation warnings.

gem 'gretel', github: 'craig1410/gretel', branch: 'dep_alias_method_chain'

@WilHall WilHall self-assigned this Jul 4, 2016

@WilHall WilHall added the maintenance label Jul 4, 2016

@WilHall WilHall merged commit af8b320 into lassebunk:master Jul 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@craig1410 craig1410 deleted the craig1410:dep_alias_method_chain branch Jul 4, 2016

@craig1410

This comment has been minimized.

Show comment
Hide comment
@craig1410

craig1410 Jul 4, 2016

Contributor

Thanks @WilHall

Contributor

craig1410 commented Jul 4, 2016

Thanks @WilHall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment