Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Declare size variable #3

Merged
merged 1 commit into from Oct 1, 2012

Conversation

Projects
None yet
2 participants
Contributor

mxcl commented Aug 22, 2012

For clang this code fails to compile, and it's not hard to see why. Frankly it is amazing it compiled with GCC and CL! What I think happened is the address of the size function from the class was used. You may want to look into that, perhaps this code is never called?

@mxcl mxcl Declare size variable
For clang this code fails to compile, and it's not hard to see why. Frankly it is amazing it compiled with GCC and CL! What I think happened is the address of the size function from the class was used. You may want to look into that, perhaps this code is never called?
25a2ef2

@evilrix evilrix added a commit that referenced this pull request Oct 1, 2012

@evilrix evilrix Merge pull request #3 from mxcl/patch-1
Declare size variable
b728727

@evilrix evilrix merged commit b728727 into lastfm:master Oct 1, 2012

Contributor

evilrix commented Oct 1, 2012

Hi.

Yeah, this function is never getting called (as far as I can tell) so as it's a template function gcc was never actually generating any code for it I guess.

Heh. Nice catch.

We generally do use clang as a 2nd compiler for all our production code (for sanity checking) but this library is pretty old and hasn't really undergone any significant changes for a while (other than structural to facilitate debian packaging) so I guess this was overlooked. Oops :)

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment