Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scrobbling on MacOS Catalina #69

Merged

Conversation

@stephen-dooley
Copy link

commented Sep 6, 2019

Breaking changes in MacOS Mojave:

MacOS Mojave introduces more stringent permissions surrounding AppleEvents.
We must include NSAppleEventsUsageDescription in the plist to grant the app permissions to talk to other apps via AppleEvents.

Breaking changes in MacOS Catalina:

MacOS Catalina no longer comes installed with iTunes (replaced with Apple Music).
We need to detect which music player is installed to support Scrobbling on Catalina.

Stephen Dooley added 2 commits Sep 6, 2019
Stephen Dooley
Support Scrobbling on MacOS Catalina.
Desktop client can detect the user's music player.
@ben-xo
Copy link
Member

left a comment

This looks great, although there are a few things which need tidying.

I'm not (yet) convinced about using homebrew QT. Should probably just peg it to a particular checked-out version.

Yet to see the change where we fix the "Open iTunes" button the app. But, this is great,

admin/dist/mac/Standard.plist Outdated Show resolved Hide resolved
admin/dist/mac/bundleFrameworks.sh Outdated Show resolved Hide resolved
admin/dist/mac/bundleFrameworks.sh Show resolved Hide resolved
changelog.txt Outdated Show resolved Hide resolved
lib/listener/mac/ITunesListener.cpp Show resolved Hide resolved
lib/listener/mac/ITunesListener.cpp Show resolved Hide resolved
@stephen-dooley

This comment has been minimized.

Copy link
Author

commented Sep 6, 2019

This looks great, although there are a few things which need tidying.

I'm not (yet) convinced about using homebrew QT. Should probably just peg it to a particular checked-out version.

Yet to see the change where we fix the "Open iTunes" button the app. But, this is great,

Would be good to tackle the "Open iTunes" button issue in a separate PR just to isolate the work.
Not sure yet what's involved, although I know where the code for generating the button is.

Re. homebrew QT - we should have a talk about pegging qt to a version. But also feels like a separate PR. Doesn't feel like it's related to fixing scrobbling.

@ben-xo
Copy link
Member

left a comment

homebrew Qt - it's related to fixing the build, so in that sense it's the most important PR to do first.

Stephen Dooley
[CR] Revert QT plugins path as it breaks build.
Error message - "On Mac OS X, you might be loading two sets of Qt binaries into the same process. Check that all plugins are compiled against the right Qt binaries."
@stephen-dooley

This comment has been minimized.

Copy link
Author

commented Sep 9, 2019

@ben-xo I reverted the change we made to point the plugins path to the homebrew Cellar. It breaks the build. You can see the error in my last commit message.

Are there any other issues with this PR?

@ben-xo ben-xo merged commit 4d36ab3 into feature/upgrade-sparkle Sep 10, 2019

@stephen-dooley stephen-dooley deleted the feature/macos-catalina-scrobbling-support branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.