Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Support Scrobbling on MacOS Catalina #69
Breaking changes in MacOS Mojave:
MacOS Mojave introduces more stringent permissions surrounding AppleEvents.
Breaking changes in MacOS Catalina:
MacOS Catalina no longer comes installed with iTunes (replaced with Apple Music).
ben-xo left a comment
This looks great, although there are a few things which need tidying.
I'm not (yet) convinced about using homebrew QT. Should probably just peg it to a particular checked-out version.
Yet to see the change where we fix the "Open iTunes" button the app. But, this is great,
Would be good to tackle the "Open iTunes" button issue in a separate PR just to isolate the work.
Re. homebrew QT - we should have a talk about pegging qt to a version. But also feels like a separate PR. Doesn't feel like it's related to fixing scrobbling.