Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix build with Qt 5.11 beta3 (drop qt5_use_modules) #36
I like to think the git messages tell that story well. Slightly confused as I don't see a ChangeLog file in the project.
Yes it should still work fine with Qt4, but since Qt4 has been removed from our repositories I have no way to test this anymore. (thinking I did test it at the time of writing the changes)
The changes are rather straightforward and in cmake only, no need for a branch.
Removing all traces of Qt4 on the other hand could be done in a separate branch, or conversely, a qt4 branch with the current state to proceed with cleanup in master.
ben-xo left a comment •
Well yes, exactly; there is nobody in-house to test it. But that doesn't contradict how I feel about pushing the change to master.
liblastfm is primarily a component of the Last.fm Desktop Client, so that is the benchmark for a successful test; and right now I don't have a set-up that can prove it will, as the build pipeline is pretty ancient.
I would be more than happen to suggest an administrative solution here, such as:
I'm also happy to listen to other suggestions.