Navigation Menu

Skip to content

Commit

Permalink
Flip --incompatible_windows_escape_python_args
Browse files Browse the repository at this point in the history
CI test results (Bazel@HEAD + Downstream):
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1003

The flag affects Windows only, and on Windows only
two projects are broken: rules_foreign_cc and
rules_nodejs.

These are also broken on other platforms, and in
the previous build:
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1002

Therefore I'm reasonably sure they are not broken
by this PR. That said, we can't completely be
sure because the tests didn't run.

See bazelbuild#7974

Change-Id: I2cc09a4e9295495062dc4ac79b859dec6512b1b7
  • Loading branch information
laszlocsomor committed May 28, 2019
1 parent 9bc841e commit 3da94b8
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -256,7 +256,7 @@ public String getTypeDescription() {

@Option(
name = "incompatible_windows_escape_python_args",
defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.OUTPUT_PARAMETERS,
effectTags = {
OptionEffectTag.ACTION_COMMAND_LINES,
Expand Down

0 comments on commit 3da94b8

Please sign in to comment.