Skip to content

Commit

Permalink
Remove invalid carbon forging protection (conversejs#1550)
Browse files Browse the repository at this point in the history
  • Loading branch information
laszlovl committed May 2, 2019
1 parent d7cd6c9 commit 77a1f76
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
5 changes: 2 additions & 3 deletions dist/converse.js
Expand Up @@ -63099,10 +63099,9 @@ _converse_core__WEBPACK_IMPORTED_MODULE_2__["default"].plugins.add('converse-cha
xmlns = Strophe.NS.CARBONS;
is_carbon = sizzle(`received[xmlns="${xmlns}"]`, stanza).length > 0;

if (is_carbon && Strophe.getBareJidFromJid(forwarded_from) !== from_jid) {
// Prevent message forging via carbons
if (is_carbon && Strophe.getBareJidFromJid(forwarded_from) !== from_jid) {// Prevent message forging via carbons
// https://xmpp.org/extensions/xep-0280.html#security
return true;
// return true;
}

is_mam = sizzle(`message > result[xmlns="${Strophe.NS.MAM}"]`, stanza).length > 0;
Expand Down
2 changes: 1 addition & 1 deletion src/headless/converse-chatboxes.js
Expand Up @@ -946,7 +946,7 @@ converse.plugins.add('converse-chatboxes', {
if (is_carbon && Strophe.getBareJidFromJid(forwarded_from) !== from_jid) {
// Prevent message forging via carbons
// https://xmpp.org/extensions/xep-0280.html#security
return true;
// return true;
}
is_mam = sizzle(`message > result[xmlns="${Strophe.NS.MAM}"]`, stanza).length > 0;
stanza = forwarded_message;
Expand Down
5 changes: 2 additions & 3 deletions src/headless/dist/converse-headless.js
Expand Up @@ -41315,10 +41315,9 @@ _converse_core__WEBPACK_IMPORTED_MODULE_2__["default"].plugins.add('converse-cha
xmlns = Strophe.NS.CARBONS;
is_carbon = sizzle(`received[xmlns="${xmlns}"]`, stanza).length > 0;

if (is_carbon && Strophe.getBareJidFromJid(forwarded_from) !== from_jid) {
// Prevent message forging via carbons
if (is_carbon && Strophe.getBareJidFromJid(forwarded_from) !== from_jid) {// Prevent message forging via carbons
// https://xmpp.org/extensions/xep-0280.html#security
return true;
// return true;
}

is_mam = sizzle(`message > result[xmlns="${Strophe.NS.MAM}"]`, stanza).length > 0;
Expand Down

0 comments on commit 77a1f76

Please sign in to comment.