Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys: move signing part out of find_by_thp() and to find_jws() #81

Merged
merged 1 commit into from Dec 14, 2021

Conversation

sergio-correia
Copy link
Collaborator

Handle just signing keys in find_jws(), to make sure we are
responding only to proper queries.

Tests were also failing to detect this issue and were updated
accordingly.

Issue discovered by Twitter Kernel and OS team during a source
code audit while evaluating Tang/Clevis for their needs.

Fixes CVE-2021-4076

Handle just signing keys in find_jws(), to make sure we are
responding only to proper queries.

Tests were also failing to detect this issue and were updated
accordingly.

Issue discovered by Twitter Kernel and OS team during a source
code audit while evaluating Tang/Clevis for their needs.

Fixes CVE-2021-4076
@codecov-commenter
Copy link

Codecov Report

Merging #81 (3503270) into master (1d1874b) will increase coverage by 1.24%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   56.10%   57.35%   +1.24%     
==========================================
  Files           3        3              
  Lines         401      401              
  Branches      115      114       -1     
==========================================
+ Hits          225      230       +5     
+ Misses         90       88       -2     
+ Partials       86       83       -3     
Impacted Files Coverage Δ
src/keys.c 59.21% <63.63%> (+1.31%) ⬆️
src/tangd.c 49.51% <0.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d1874b...3503270. Read the comment docs.

Copy link
Collaborator

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. Thanks for the fix.

I like the change on the tests. From my perspective, they are more readable now.

@sarroutbi sarroutbi merged commit e82459f into latchset:master Dec 14, 2021
10 checks passed
@sergio-correia sergio-correia deleted the find_jws branch December 14, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants