Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log complete URL when tracking page views #4

Merged
merged 3 commits into from Apr 18, 2019

Conversation

Projects
None yet
2 participants
@victorjonsson
Copy link
Contributor

commented Apr 17, 2019

Feel free to merge this pull request if it is to your liking. It will change the module in the following way:

  • The config variable basePath is renamed to baseName. Since the variable is used to prefix the name of the pageView this name made more sense.
  • It will register the name of the route instead of the path as name in app insight. Duplicating the path of the route doesn't make much sense
  • It ensures that the entire url of the route is logged, not only the relative path of the route.

Cheers!

victorjonsson and others added some commits Apr 17, 2019

@Alxios

Alxios approved these changes Apr 18, 2019

@Alxios Alxios merged commit 594643f into latelierco:master Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.