Space before date optional argument to \ProvidesPackage causes error

[josephwright]

Brief outline of the bug

As reported on the TeX Live list, with the 2018-04-01 release of the kernel there is a low-level error when a .sty file (or similar) has a space between the [ and date in the optional argument to \ProvidesPackage.

Minimal example showing the bug

\RequirePackage{latexbug}
\begin{filecontents}{test.sty}
\ProvidesPackage{test}%
  [ 2018/04/08 v0.0 Test Package. ]
\end{filecontents}
\documentclass{article}
\usepackage{test}
\begin{document}
Hello, World!
\end{document}
\begin{document}

Log file (required) and possibly PDF file

ex2.log

[josephwright]

Suggested code change:

\makeatletter
\def\@ifl@t@r#1#2{%
  \ifnum\expandafter\@parse@version\expandafter#1//00\@nil<%
        \expandafter\@parse@version\expandafter#2//00\@nil
    \expandafter\@secondoftwo
  \else
    \expandafter\@firstoftwo
  \fi}
\def\@parse@version#1{\@parse@version@0#1}
\def\@parse@version@#1/#2/#3#4#5\@nil{%
\@parse@version@dash#1-#2-#3#4\@nil
}
\makeatother

[eg9]

On 8 Apr 2018, at 11:21 , Joseph Wright ***@***.***> wrote: Suggested code change: [...]

Agreed, this can catch weird errors when `[` in `\ProvidesPackage` is at the end of a line by itself, for instance. Ciao Enrico

[josephwright]

I'd change this but latexrelease makes life tricky: one for @davidcarlisle I think ;)

[josephwright]

(Note I've edited my suggested code: I had a stray \@nil)

[davidcarlisle]

OK, I'll do it (but if we are changing in a patch release) then no need for any additional latex release markup

…

On 8 April 2018 at 12:15, Joseph Wright ***@***.***> wrote: I'd change this but latexrelease makes life tricky: one for @davidcarlisle <https://github.com/davidcarlisle> I think ;) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABNcAsc4pHSErAxlzPDWkK-O53MR7qyMks5tmfFggaJpZM4TLdob> .

[josephwright]

@davidcarlisle I meant that one had to move where the 0 business is added, and that is a change from previous versions so presumably does need the PL stuff.

[davidcarlisle]

@josephwright a simper change with less impact of latexrelease.sty would be

\def\@ifl@t@r#1#2{%
  \ifnum\expandafter\@parse@version@#1//00\@nil<%
        \expandafter\@parse@version@#2//00\@nil
    \expandafter\@secondoftwo
  \else
    \expandafter\@firstoftwo
  \fi}
\def\@parse@version@#1{\@parse@version0#1}

[josephwright]

@davidcarlisle Sure: I was just looking for a 'quick fix'.