New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap #38

Open
lathonez opened this Issue Mar 9, 2016 · 18 comments

Comments

Projects
None yet
5 participants
@lathonez

This comment has been minimized.

Show comment
Hide comment
@lathonez
Owner

lathonez commented Mar 9, 2016

@marcmeans - FYI

@lathonez

This comment has been minimized.

Show comment
Hide comment
@lathonez

lathonez Mar 9, 2016

Owner

Linting

tslint should work out of the box if you have a tslint.json. If you would like further enhancements to linting please raise an issue and explain there.

Owner

lathonez commented Mar 9, 2016

Linting

tslint should work out of the box if you have a tslint.json. If you would like further enhancements to linting please raise an issue and explain there.

@lathonez

This comment has been minimized.

Show comment
Hide comment
@lathonez

lathonez Mar 9, 2016

Owner

Testing with watches

Was implemented in #19. Explained in the blog and readme. If you would like further enhancements to this please raise an issue and explain there.

Owner

lathonez commented Mar 9, 2016

Testing with watches

Was implemented in #19. Explained in the blog and readme. If you would like further enhancements to this please raise an issue and explain there.

@lathonez

This comment has been minimized.

Show comment
Hide comment
@lathonez

lathonez Mar 9, 2016

Owner

examples of tests mocking observables/promises

I don't want this repo to turn into a "how to unit test" thing. It's a rabbit hole and I don't have the time or inclination to support it.

That being said there are certain things that I think are worth including, for example, testing Ionic @Pages using angular2 dependency injection, which is not done yet - though components are.

The best place for general unit testing questions probably stack overflow. There is an example with promises in clickers.spec.ts (most of the complex examples are therein).

Owner

lathonez commented Mar 9, 2016

examples of tests mocking observables/promises

I don't want this repo to turn into a "how to unit test" thing. It's a rabbit hole and I don't have the time or inclination to support it.

That being said there are certain things that I think are worth including, for example, testing Ionic @Pages using angular2 dependency injection, which is not done yet - though components are.

The best place for general unit testing questions probably stack overflow. There is an example with promises in clickers.spec.ts (most of the complex examples are therein).

@lathonez

This comment has been minimized.

Show comment
Hide comment
@lathonez

lathonez Mar 9, 2016

Owner

put example code in module structure for easy removal and showing pattern

@marcmeans - sounds interesting, but I don't know what you mean? Maybe raise an issue with some explanation?

Owner

lathonez commented Mar 9, 2016

put example code in module structure for easy removal and showing pattern

@marcmeans - sounds interesting, but I don't know what you mean? Maybe raise an issue with some explanation?

@geoHeil

This comment has been minimized.

Show comment
Hide comment
@geoHeil

geoHeil Jun 16, 2016

What about Hot Module Replacement?

geoHeil commented Jun 16, 2016

What about Hot Module Replacement?

@lathonez

This comment has been minimized.

Show comment
Hide comment
@lathonez

lathonez Jun 18, 2016

Owner

@geoHeil are you suggesting a move back to webpack (wouldn't happen unless Ionic went back again), or using browserify-hmr?

or something else?

Owner

lathonez commented Jun 18, 2016

@geoHeil are you suggesting a move back to webpack (wouldn't happen unless Ionic went back again), or using browserify-hmr?

or something else?

@geoHeil

This comment has been minimized.

Show comment
Hide comment
@geoHeil

geoHeil Jun 18, 2016

Not sure about implementation details, just saying HMR would be cool. As such browserify-hmr seems to be fine.

geoHeil commented Jun 18, 2016

Not sure about implementation details, just saying HMR would be cool. As such browserify-hmr seems to be fine.

@lathonez

This comment has been minimized.

Show comment
Hide comment
@lathonez

lathonez Jun 18, 2016

Owner

just saying HMR would be cool

agreed

Owner

lathonez commented Jun 18, 2016

just saying HMR would be cool

agreed

@ddellamico

This comment has been minimized.

Show comment
Hide comment
@ddellamico

ddellamico Aug 12, 2016

In this post, seems Ionic team are migrating again from Browserify to Webpack 2 to take advantage of "tree shaking." .. It would be nice start moving this project to webpack.. what do you think ?

ddellamico commented Aug 12, 2016

In this post, seems Ionic team are migrating again from Browserify to Webpack 2 to take advantage of "tree shaking." .. It would be nice start moving this project to webpack.. what do you think ?

@lathonez

This comment has been minimized.

Show comment
Hide comment
@lathonez

lathonez Aug 12, 2016

Owner

Yeah, if they do end up going with webpack2 in beta12 we'll switch over as
part of incorporating that upgrade into this repo.

I don't think it's worth doing ahead of time.

On 13 Aug 2016 02:44, "Damien" notifications@github.com wrote:

In this post http://blog.ionic.io/announcing-ionic-2-beta-11/, seems
Ionic team are migrating again from Browserify to Webpack 2 to take
advantage of "tree shaking." .. It would be nice start moving this project
to webpack.. what do you think ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#38 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG5tSHHF88L9uMX8Eu6Btm0xCshvzM79ks5qfKLUgaJpZM4Hsebj
.

Owner

lathonez commented Aug 12, 2016

Yeah, if they do end up going with webpack2 in beta12 we'll switch over as
part of incorporating that upgrade into this repo.

I don't think it's worth doing ahead of time.

On 13 Aug 2016 02:44, "Damien" notifications@github.com wrote:

In this post http://blog.ionic.io/announcing-ionic-2-beta-11/, seems
Ionic team are migrating again from Browserify to Webpack 2 to take
advantage of "tree shaking." .. It would be nice start moving this project
to webpack.. what do you think ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#38 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG5tSHHF88L9uMX8Eu6Btm0xCshvzM79ks5qfKLUgaJpZM4Hsebj
.

@marcoturi

This comment has been minimized.

Show comment
Hide comment
@marcoturi

marcoturi Sep 1, 2016

Would be good to have same code documentation, maybe through typedoc ?

marcoturi commented Sep 1, 2016

Would be good to have same code documentation, maybe through typedoc ?

@lathonez

This comment has been minimized.

Show comment
Hide comment
@lathonez

lathonez Sep 1, 2016

Owner

@marcoturi - agreed. I've opened #139.

If you're feeling generous, a small PR would be fantastic.

If not thanks a lot for the suggestion, will do my best get round to it!

Owner

lathonez commented Sep 1, 2016

@marcoturi - agreed. I've opened #139.

If you're feeling generous, a small PR would be fantastic.

If not thanks a lot for the suggestion, will do my best get round to it!

@thielCole

This comment has been minimized.

Show comment
Hide comment
@thielCole

thielCole Nov 11, 2016

@lathonez Have you put any thought into doing e2e testing on actual devices or through an emulator?

thielCole commented Nov 11, 2016

@lathonez Have you put any thought into doing e2e testing on actual devices or through an emulator?

@lathonez

This comment has been minimized.

Show comment
Hide comment
@lathonez

lathonez Nov 11, 2016

Owner

#52 (top of the list). Last time I looked SauceLabs was the best option for FOSS.

Realistically I don't have any time for moving this roadmap forward (until my associated closed source project requires it).

Very happy for PRs / discussion suggestions around the correct direction.

Owner

lathonez commented Nov 11, 2016

#52 (top of the list). Last time I looked SauceLabs was the best option for FOSS.

Realistically I don't have any time for moving this roadmap forward (until my associated closed source project requires it).

Very happy for PRs / discussion suggestions around the correct direction.

@thielCole

This comment has been minimized.

Show comment
Hide comment
@thielCole

thielCole Nov 11, 2016

Ah it was hidden in the name. Yeah I'm currently checking out both a SauceLabs solution and Appium.

thielCole commented Nov 11, 2016

Ah it was hidden in the name. Yeah I'm currently checking out both a SauceLabs solution and Appium.

@lathonez

This comment has been minimized.

Show comment
Hide comment
@lathonez

lathonez Nov 11, 2016

Owner

If you come up with something that works let us know, maybe share config.

Thanks

Owner

lathonez commented Nov 11, 2016

If you come up with something that works let us know, maybe share config.

Thanks

@lathonez

This comment has been minimized.

Show comment
Hide comment
@lathonez

lathonez Feb 27, 2017

Owner

Now we're using @angular/cli, anything in the test direction should be raised upstream there. We'll take any features they add.

Owner

lathonez commented Feb 27, 2017

Now we're using @angular/cli, anything in the test direction should be raised upstream there. We'll take any features they add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment