some bug fixes #114
Merged
some bug fixes #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerrleblond
approved these changes
Feb 26, 2024
gwwatkin
reviewed
Mar 1, 2024
Comment on lines
+128
to
+136
| if(split.size() != 2) { | ||
| //Is this an angle of the form 3*pi? | ||
| // not sure why but maybe we need something like | ||
| std::string ns = std::string(s) + "/1"; | ||
|
|
||
| split = lstk::split_on(ns,"*pi/"); | ||
| if(split.size() != 2) | ||
| throw GateParseException{lstk::cat("Could not parse angle ", s, " as n*pi/m")}; | ||
| } |
There was a problem hiding this comment.
Yeah, this parser could for sure be more robust, starting from having a datatype to actually store fractions. Ideally we find a good header only library to parse and represent fractions
There was a problem hiding this comment.
there is a datatype for fractions, but was not sure how to use it for our purposes. I would not invest time in qasm parser, as i would expect somebody will eventually provide one open source on github
gwwatkin
requested changes
Mar 1, 2024
gwwatkin
reviewed
Mar 1, 2024
gwwatkin
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.