fix(cli): don't deploy abstract contracts (#3669)

Author: frolic

.changeset/thin-bees-hug.md

@@ -0,0 +1,6 @@
+---
+"@latticexyz/cli": patch
+"@latticexyz/common": patch
+---
+
+CLI will no longer deploy abstract systems and contracts without bytecode.

packages/cli/src/deploy/resolveConfig.ts

@@ -3,13 +3,14 @@ import { loadSystemsManifest, resolveSystems } from "@latticexyz/world/node";
 import { Library, System, WorldFunction } from "./common";
 import { Hex, isHex, toFunctionSelector, toFunctionSignature } from "viem";
 import { getContractData } from "../utils/getContractData";
-import { groupBy } from "@latticexyz/common/utils";
+import { groupBy, isDefined } from "@latticexyz/common/utils";
 import { findLibraries } from "./findLibraries";
 import { createPrepareDeploy } from "./createPrepareDeploy";
 import { World } from "@latticexyz/world";
 import { findUp } from "find-up";
 import { createRequire } from "node:module";
 import { excludeCallWithSignatureModule } from "./compat/excludeUnstableCallWithSignatureModule";
+import { debug } from "./debug";
 
 // TODO: replace this with a manifest/combined config output
 
@@ -63,7 +64,7 @@ export async function resolveConfig({
 
   const systems = configSystems
     .filter((system) => !system.deploy.disabled)
-    .map((system): System => {
+    .map((system): System | undefined => {
       const manifest = systemsManifest.systems.find(({ systemId }) => systemId === system.systemId);
       if (!manifest) {
         throw new Error(
@@ -72,6 +73,11 @@ export async function resolveConfig({
       }
 
       const contractData = getContractData(`${system.label}.sol`, system.label, forgeOutDir);
+      if (!contractData.deployedBytecodeSize) {
+        // abstract contracts have no bytecode
+        debug(`skipping ${system.label} system with no bytecode`);
+        return;
+      }
 
       // TODO: replace this with manifest
       const worldFunctions = system.deploy.registerWorldFunctions
@@ -115,7 +121,8 @@ export async function resolveConfig({
           worldAbi: manifest.worldAbi,
         },
       };
-    });
+    })
+    .filter(isDefined);
 
   // Check for overlapping system IDs (since names get truncated when turning into IDs)
   // TODO: move this into the world config resolve step once it resolves system IDs

packages/common/src/deploy/ensureContract.ts

@@ -35,6 +35,10 @@ export async function ensureContract({
   }
 
   if (deployedBytecodeSize != null) {
+    if (deployedBytecodeSize === 0) {
+      throw new Error(`Empty bytecode for ${debugLabel}`);
+    }
+
     if (deployedBytecodeSize > contractSizeLimit) {
       console.warn(
         `\nBytecode for ${debugLabel} (${deployedBytecodeSize} bytes) is over the contract size limit (${contractSizeLimit} bytes). Run \`forge build --sizes\` for more info.\n`,

packages/world/ts/node/getSystemContracts.ts

@@ -27,7 +27,6 @@ export async function getSystemContracts({
 
   const files = await Promise.all(
     filePaths.map(async (file) => {
-      console.log("reading source for", file.filename);
       const source = await fs.readFile(path.join(rootDir, file.filename), "utf-8");
       return { ...file, source };
     }),

test/system-libraries/src/codegen/world/ISomeAbstractProgram.sol

@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: MIT
+pragma solidity >=0.8.28;
+
+import { System } from "@latticexyz/world/src/System.sol";
+
+abstract contract SomeAbstractProgram is System {
+  function abstractExecute() public {}
+}

test/system-libraries/src/codegen/world/ISomeProgram.sol

@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: MIT
+pragma solidity >=0.8.28;
+
+import { System } from "@latticexyz/world/src/System.sol";
+
+contract SomeProgram is System {
+  function execute() public {}
+}