feat(relay): check message data doesn't exceed a configurable limit #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I also add a flag to the configuration to set wether the size limit is enforced, like we do for signature verification and account balance? @authcall |
yes that sounds good. I think something like |
authcall
previously approved these changes
Nov 3, 2022
authcall
previously approved these changes
Nov 3, 2022
authcall
approved these changes
Nov 3, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
…igurable limit (#195) * feat(relay): check message data doesn't exceed a configurable limit * feat(relay): add config flag to enforce data size limit * fix: revert typos * fix: revert more not needed changes * Update README.md Co-authored-by: authcall <authcall@proton.me>
LPSCRYPT
pushed a commit
to LPSCRYPT/esp
that referenced
this pull request
Jan 23, 2023
…atticexyz#195) * feat(relay): check message data doesn't exceed a configurable limit * feat(relay): add config flag to enforce data size limit * fix: revert typos * fix: revert more not needed changes * Update README.md Co-authored-by: authcall <authcall@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the data field of a relayed message can have an arbitrary size so it's possible for an attacker to send a giant message. This PR adds a field to the relay server configuration specifying a size limit for message data.