feat: new systems pattern #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvrs
commented
Jul 8, 2022
| @@ -120,6 +122,7 @@ async function bootLayers() { | |||
| disposeLayer("local"); | |||
| disposeLayer("phaser"); | |||
| await bootLayers(); | |||
| await bootReact(layers as Layers); | |||
There was a problem hiding this comment.
Reboot react when the network layer reboots, because block streams etc will be different
alvrs
commented
Jul 8, 2022
| moveEntity: (entity: EntityIndex, direction: Direction) => { | ||
| "no-op for types"; | ||
| }, | ||
| moveEntity: curry(moveEntity)({ world, actions, network, LocalStamina }), |
There was a problem hiding this comment.
there is a circular dependency if the api functions take the layer as input, leading to type issues, we need to find a better solution for this
Kooshaba
previously approved these changes
Jul 8, 2022
| @@ -0,0 +1,90 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
do we want to commit these generated files?
Co-authored-by: Andy Cernera <kooshaba@gmail.com>
Kooshaba
previously approved these changes
Jul 8, 2022
davidkol
reviewed
Jul 8, 2022
|
|
||
| - Systems must implement the `ISystem` interface. | ||
| - Systems must declare an ID following this pattern: `uint256 constant ID = uint256(keccak256("<UNIQUE SYSTEM IDENTIFIER>"));` | ||
| - System contracs must be named exactly the same as the file containing them. |
davidkol
reviewed
Jul 8, 2022
| } | ||
|
|
||
| function requirement(bytes memory) public view returns (bytes memory) { | ||
| // NOTE: Make sure to not include this system in a production deployment, as anyone can cahnge all component values |
davidkol
approved these changes
Jul 8, 2022
LPSCRYPT
pushed a commit
to LPSCRYPT/esp
that referenced
this pull request
Jan 23, 2023
* feat: add systems interface, systemsComponent, registerSystem * chore: clean up * feat: add client mappings for componentComponent, systemComponent * fix: fix hot reloading react * feat: wip MoveSystem * feat: remove diamond * feat: add createSystemExecutor * feat: autogenerate system abis and types * refactor: move from facets to systems, remove persona * refactor: integrate LibStamina, GameConfigSystem * chore: clean up * refactor: port LibECS * refactor: split up DebugFacets into ComponentDevSystem and BulkUploadSystem * chore: remove unused params from deploy script * fix: self review * fix: remove unused console log in Component.sol Co-authored-by: Andy Cernera <kooshaba@gmail.com> * build(cli): gitignore build files, build on prepare * fix: typos Co-authored-by: Andy Cernera <kooshaba@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
componentComponent(a component on the world that stores all registered components) andsystemComponent(a component on the world that stores all registered systems) to automatically and dynamically sync existing components and systems to the client -> next step is to dynamically display systems that entities can call when selecting an entityyarn buildin the contracts folder, thesystemsobject on the client (network layer) automatically contains all existing systems and their typed methods (integrated with the txQueue), so developers can simply call existing systems from there.Followups: