feat: replace Schema with FieldLayout for contract internals

[dk1a]

fixes #1326
see the changeset for more context on this change

[changeset-bot]

🦋 Changeset detected

Latest commit: 5e993cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages

Name	Type
@latticexyz/cli	Major
@latticexyz/protocol-parser	Major
@latticexyz/store	Major
@latticexyz/world	Major
@latticexyz/store-sync	Major
@latticexyz/dev-tools	Major
@latticexyz/react	Major
@latticexyz/store-indexer	Major
@latticexyz/abi-ts	Major
@latticexyz/block-logs-stream	Major
@latticexyz/common	Major
@latticexyz/config	Major
create-mud	Major
@latticexyz/ecs-browser	Major
@latticexyz/gas-report	Major
@latticexyz/network	Major
@latticexyz/noise	Major
@latticexyz/phaserx	Major
@latticexyz/recs	Major
@latticexyz/schema-type	Major
@latticexyz/services	Major
@latticexyz/solecs	Major
solhint-config-mud	Major
solhint-plugin-mud	Major
@latticexyz/std-client	Major
@latticexyz/std-contracts	Major
@latticexyz/store-cache	Major
@latticexyz/utils	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[alvrs]

High level feedback on terminology: I think we should keep calling the array of schema types "schema", which is the thing that is used by off-chain consumers to know how to interpret the data, and we should find a new name for the "static byte lengths" object used internally by Store and the table libraries. Otherwise it gets confusing if we use "Schema" for one thing onchain and another thing offchain.

[dk1a]

I think we should keep calling the array of schema types "schema"

Technically no more schema types, just abi types (I wanna ditch the enum and replace it with bytes32 strings that directly mirror config/client).
They can still be called Schema. Or we could rename to something like AbiTypes. getValueAbiTypes getKeyAbiTypes? (doesn't sound as good I guess)

we should find a new name for the "static byte lengths"

Agree, FieldMetadata FieldInfo? This stores the number of fields and their lengths, so FieldLengths wouldn't really work.

[alvrs]

do you think these increases in gas are a result of the previous measurements being invalid (because of #1267) or is using constants instead of hardcoded values somehow more expensive?

[dk1a]

dunno, I assume it's #1267, but could be the optimizer being bad too

[alvrs]

code looks good! good to be merged once merge conflicts are resolved

[frolic]

these files snuck back in 😭