feat(store,world): more granularity for onchain hooks

[alvrs]

Fixes #1159 (that issue also includes more context on this approach vs different approaches)

TODOs

• Split onSetRecord into onBeforeSetRecord and onAfterSetRecord
• Split onDeleteRecord into onBeforeDeleteRecord and onAfterDeleteRecord
• Add a bitmap to the store hooks and system hooks: One bit for each operation, so we can skip unnecessary calls.
• Rename EnableHooks to EnableStoreHooks and each element from beforeX to onBeforeX etc

TODOs in follow ups

• Add ability to remove hooks (by filtering the array). Since it's possible to upgrade systems now it seems useful to be able to remove hooks and register new ones.
• Consider renaming all mentions of "Hook" to "Hooks" (since now that individual functions can be enabled and disabled that makes more sense)

TODOs depending on #1354

• Remove onBeforeSetField and onAfterSetField
• Add onBeforeSpliceRecord and onAfterSpliceRecord

[changeset-bot]

🦋 Changeset detected

Latest commit: 5464530

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages

Name	Type
@latticexyz/store	Major
@latticexyz/world	Major
@latticexyz/cli	Major
@latticexyz/dev-tools	Major
@latticexyz/react	Major
@latticexyz/store-indexer	Major
@latticexyz/store-sync	Major
@latticexyz/abi-ts	Major
@latticexyz/block-logs-stream	Major
@latticexyz/common	Major
@latticexyz/config	Major
create-mud	Major
@latticexyz/ecs-browser	Major
@latticexyz/gas-report	Major
@latticexyz/network	Major
@latticexyz/noise	Major
@latticexyz/phaserx	Major
@latticexyz/protocol-parser	Major
@latticexyz/recs	Major
@latticexyz/schema-type	Major
@latticexyz/services	Major
@latticexyz/solecs	Major
solhint-config-mud	Major
solhint-plugin-mud	Major
@latticexyz/std-client	Major
@latticexyz/std-contracts	Major
@latticexyz/store-cache	Major
@latticexyz/utils	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[frolic]

[frolic]

ooc is this more gas efficient than the reverse?

[alvrs]

I think it shouldn't make a difference, wdyt @dk1a? Could try it out (either here or in a follow up gas optimization pass)

[frolic]

I wonder if this would also work

EnabledStoreHooks({
  onBeforeSetRecord: true,
  onBeforeSetField: true,
  onBeforeDeleteRecord: true
})

(only toggling on the ones we want and letting the others default, but not sure if solc will complain)

[frolic]

I also wonder if we should just use a unit8 here instead of the struct so that the ABI (and presumably abi-encoded calldata) is a bit more compact vs (bool,bool,bool,bool,...)

[alvrs]

unfortunately solc does complain :(

[alvrs]

I also wonder if we should just use a unit8 here

yeah i think you're right here - we just have to document how to use the helper libraries to encode the bitmap, but it would be much cheaper to encode it in eg. the module the hook is registered and only pass the uint8 between contracts.