feat(world,store): add initialize method, initialize core tables in core module#1472
feat(world,store): add initialize method, initialize core tables in core module#1472
Conversation
🦋 Changeset detectedLatest commit: 59796f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| } | ||
|
|
||
| function installRoot(bytes memory) public override { | ||
| StoreCore.registerCoreTables(); |
There was a problem hiding this comment.
wondering if this should be in _registerCoreTables
.changeset/tricky-beds-kiss.md
Outdated
| --- | ||
| "@latticexyz/cli": patch | ||
| "@latticexyz/store": patch | ||
| "@latticexyz/world": patch |
There was a problem hiding this comment.
ohh true forgot it there. Could do that in a separate followup though, this PR doesn't actually use the WorldFactory yet (because calling initialize in a separate transaction is supported it's not strictly necessary.)
frolic
left a comment
There was a problem hiding this comment.
wooo 4kb is a good chunk of savings
.changeset/tricky-beds-kiss.md
Outdated
|
|
||
| - The `StoreRead` contract no longer calls `StoreCore.initialize` in its constructor. | ||
| `StoreCore` consumers are expected to call `StoreCore.initialize` and `StoreCore.registerCoreTable` in their own setup logic. |
There was a problem hiding this comment.
| - The `StoreRead` contract no longer calls `StoreCore.initialize` in its constructor. | |
| `StoreCore` consumers are expected to call `StoreCore.initialize` and `StoreCore.registerCoreTable` in their own setup logic. |
moving this to its own changeset bc it's the only major change
purpose is to save a lot of bytecode in the
WorldandWorldFacorycontracts