Skip to content

feat(protoocl-parser): add valueSchemaToFieldLayoutHex#1476

Merged
frolic merged 2 commits intomainfrom
holic/value-schema-to-field-layout
Sep 14, 2023
Merged

feat(protoocl-parser): add valueSchemaToFieldLayoutHex#1476
frolic merged 2 commits intomainfrom
holic/value-schema-to-field-layout

Conversation

@frolic
Copy link
Member

@frolic frolic commented Sep 14, 2023

I lost track of where the comment was but I said I'd swap out fieldLayoutToHex with a thing that uses ValueSchema. This should help with #1466 cc @y77cao

Unfortunately we don't have Solidity tests that map a raw bytes32 value to FieldLayout so I can copy that over to make sure the Solidity and TS line up in terms of behavior, padding, etc. So I skipped adding tests for now.

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

🦋 Changeset detected

Latest commit: f091db4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@latticexyz/protocol-parser Major
@latticexyz/cli Major
@latticexyz/store-sync Major
@latticexyz/dev-tools Major
@latticexyz/store-indexer Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/ecs-browser Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/react Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/store Major
@latticexyz/utils Major
@latticexyz/world Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@frolic frolic marked this pull request as ready for review September 14, 2023 10:14
@frolic frolic requested a review from alvrs as a code owner September 14, 2023 10:14
alvrs
alvrs previously approved these changes Sep 14, 2023
@alvrs
Copy link
Member

alvrs commented Sep 14, 2023

let's add a changeset!

@frolic frolic merged commit 9ff4dd9 into main Sep 14, 2023
@frolic frolic deleted the holic/value-schema-to-field-layout branch September 14, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants