feat(world-modules): add SystemSwitch util - #1665
Merged
Merged
Conversation
alvrs
commented
Sep 29, 2023
alvrs
commented
Member
- util for better ergonomics of calling systems from other systems
🦋 Changeset detectedLatest commit: 19e1ef2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
frolic
reviewed
Sep 29, 2023
| @@ -0,0 +1,80 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity >=0.8.21; | |||
Member
There was a problem hiding this comment.
talked IRL but can we move this to src/utils instead of stc/modules/utils since it's not a module?
in the future we can consider renaming this package to world-std
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alvrs
force-pushed
the
alvrs/subsystem-call
branch
from
October 3, 2023 11:39
8aeceb8 to
f9d0d36
Compare
alvrs
marked this pull request as ready for review
October 3, 2023 11:54
frolic
reviewed
Oct 3, 2023
|
|
||
| + // ...you can now use the `SystemSwitch` util. | ||
| * // This works independent of whether used in a root system or non-root system. | ||
| + SystemSwitch.call(abi.encodeCall(IBaseWorld.callMySystem, ()); |
Member
There was a problem hiding this comment.
do we want to show how this is used with return values? since this requires abi.decode now, whereas the former didn't
Member
Author
There was a problem hiding this comment.
yes, if the call returns a value. Will change in the changeset example.
frolic
previously approved these changes
Oct 3, 2023
Member
|
since we've had a few folks ask about this, we should prob get @qbzzt to add a docs page about systems-calling-systems |
alvrs
commented
Oct 3, 2023
frolic
reviewed
Oct 3, 2023
| - uint256 value = IBaseWorld(_world()).callMySystem(); | ||
|
|
||
| + // ...you can now use the `SystemSwitch` util. | ||
| * // This works independent of whether used in a root system or non-root system. |
alvrs
commented
Oct 3, 2023
frolic
approved these changes
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.