From b0a7659f4d79d011aa1274a138e4b18952f5f44a Mon Sep 17 00:00:00 2001 From: Scott Moses Sunarto Date: Thu, 10 Feb 2022 15:50:34 -0800 Subject: [PATCH] minor refactor --- src/Persona.sol | 6 +----- src/test/Persona.t.sol | 4 ++-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/Persona.sol b/src/Persona.sol index 03558e5..1701efe 100644 --- a/src/Persona.sol +++ b/src/Persona.sol @@ -83,10 +83,6 @@ contract Persona is ERC721 { owner = newContractOwner; } - function getOwner(uint256 personaId) public view returns (address) { - return ownerOf[personaId]; - } - /*/////////////////////////////////////////////////////////////// VIEW //////////////////////////////////////////////////////////////*/ @@ -126,7 +122,7 @@ contract Persona is ERC721 { return getAuthorization(personaId, user, consumer).isAuthorized; } else if (getPermission(personaId, user) == PersonaPermission.FUNCTION_SPECIFIC) { // TODO: Fix this hacky solution - if(fnSignature == bytes4(0)) { + if (fnSignature == bytes4(0)) { return true; } bytes4[] memory fns = getAuthorization(personaId, user, consumer).authorizedFns; diff --git a/src/test/Persona.t.sol b/src/test/Persona.t.sol index f12d8c7..c1c34f4 100644 --- a/src/test/Persona.t.sol +++ b/src/test/Persona.t.sol @@ -290,7 +290,7 @@ contract PersonaTest is BaseTest { vm.stopPrank(); } - /// Transfer \\\ + /// Transfer \\\ function testTransferOwnership() public { uint256 id = _mintTo(personaOwner); @@ -298,7 +298,7 @@ contract PersonaTest is BaseTest { persona.transferFrom(address(personaOwner), address(alice), id); vm.stopPrank(); - assertTrue(persona.getOwner(id) == address(alice)); + assertTrue(persona.ownerOf(id) == address(alice)); } function testTransferRemovesAuthorization() public {