Fix for submodules display & graphing memory leak #163

merged 3 commits into from Mar 28, 2012


None yet
2 participants

greay commented Feb 25, 2012

2 minor fixes:

  • it appears (at least on Lion) that git submodules are never showing up in the sidebar because the KVO notifications are never fired. Changing PBSubmoduleController's modules ivar to a property fixes this.
  • ARC does not automatically free malloc'ed memory. This was creating a leak in PBGraphCellInfo because the lines ivar is never freed. Added a -dealloc method (which is still called under ARC) to clean it up.

laullon commented Feb 28, 2012

there is a merge conflict, can you solve it?

greay commented Feb 29, 2012

my fix for submodules was made redundant by 94e722b, so I just reverted my commit for that issue. I believe the other issue should still be valid, though

@laullon laullon added a commit that referenced this pull request Mar 28, 2012

@laullon laullon Merge pull request #163 from greay/fixes
Fix for submodules display & graphing memory leak

@laullon laullon merged commit daae73a into laullon:master Mar 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment