Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rustfix coverage tracking #167

Merged
merged 2 commits into from Jul 16, 2019

Conversation

@phansch
Copy link
Contributor

commented Mar 26, 2019

Pretty much a copy of rust-lang/rust#59398 and
rust-lang/rust#59677 minus the rustc bootstrap
things.

This will allow rustfix coverage tracking in Clippy and other
libraries that emit MachineApplicable diagnostics.

phansch added 2 commits Mar 26, 2019
Add support for rustfix coverage tracking
Pretty much a copy of rust-lang/rust#59398 minus
the rustc bootstrap things.

This will allow rustfix coverage tracking in Clippy and other
libraries that emit `MachineApplicable` diagnostics.

@phansch phansch closed this Apr 16, 2019

@phansch phansch reopened this Apr 16, 2019

@phansch

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

Let me know if there's something I can help out with. It would be nice to get this merged so we can update rust-lang/rust-clippy#3630.

@phansch

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

@laumann would you be up for merging this and releasing a new version? It would be a big help for getting good rustfix test coverage in Clippy

edit: woops, Manish was faster, sorry about the ping =)

@Manishearth Manishearth merged commit ffdcb7f into laumann:master Jul 16, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@phansch phansch deleted the phansch:rustfix_coverage branch Jul 16, 2019

@laumann

This comment has been minimized.

Copy link
Owner

commented Jul 18, 2019

@phansch Sorry for being so tardy, compiletest has gotten away from me a little bit.

@laumann

This comment has been minimized.

Copy link
Owner

commented Jul 18, 2019

Was a new version released? 0.3.22 looks to be from April, so should this go in 0.3.23?

@phansch

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

@laumann No worries at all.

I think for this particular PR no new version is required because it's enough to update the rustfix coverage issue using the compiletest-rs master branch temporarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.