Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a proc-macro UI test example to the test project #171

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@phansch
Copy link
Contributor

commented Apr 7, 2019

Taken from work on rust-lang/rust-clippy#3741.

I think this is a useful test to have because it tests

  • the run-pass header
  • the aux-build header, building auxiliary files
  • the no-prefer-dynamic header
  • proc-macro crate interactions with all of the above
  • running of UI tests that include auxiliary files

There's no tests for any of the above right now.

@phansch phansch closed this Apr 16, 2019
@phansch phansch reopened this Apr 16, 2019
@Munksgaard

This comment has been minimized.

Copy link
Collaborator

commented Aug 21, 2019

Now that #183 has been merged, could you rebase this PR so we can merge it?

@phansch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

Sure, will do it later today!

@phansch phansch force-pushed the phansch:proc_macro_extern_run_pass branch 2 times, most recently from 8fe696d to 11067da Aug 21, 2019
@phansch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

Since the test requires a nightly-only feature, I added a new nightly-only test suite that is not activated when the stable feature is enabled. This should fix the tests.

Taken from work on rust-lang/rust-clippy#3741.

I think this is a useful test to have because it tests

* the `run-pass` header
* the `aux-build` header, building auxiliary files
* the `no-prefer-dynamic` header
* proc-macro crate interactions with all of the above
* running of UI tests that include auxiliary files

There's no tests for any of the above right now.
@phansch phansch force-pushed the phansch:proc_macro_extern_run_pass branch from e12e879 to 4f1f614 Aug 21, 2019
@Munksgaard Munksgaard merged commit 1ccbcfe into laumann:master Sep 10, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@phansch phansch deleted the phansch:proc_macro_extern_run_pass branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.